Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-29 Thread Sebastian Reichel
Hi, On Sat, Jan 28, 2017 at 02:30:22PM +, Jonathan Cameron wrote: > On 27/01/17 08:20, Maxime Ripard wrote: > > On Thu, Jan 26, 2017 at 02:32:21PM +0100, Quentin Schulz wrote: > >> I've come with this solution: > >> > >>

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-28 Thread Jonathan Cameron
On 27/01/17 08:20, Maxime Ripard wrote: > On Thu, Jan 26, 2017 at 02:32:21PM +0100, Quentin Schulz wrote: >> I've come with this solution: >> >> >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 012c064..117

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-27 Thread Maxime Ripard
On Thu, Jan 26, 2017 at 02:32:21PM +0100, Quentin Schulz wrote: > I've come with this solution: > > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 012c064..117eacb 100644 > --- a/drivers/mfd/axp20x.c > +++

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-26 Thread Quentin Schulz
Hi Sebastian, On 17/01/2017 04:00, Sebastian Reichel wrote: > Hi Quentin, > > The driver looks mostly fine. I do have a two comments, though. > > On Mon, Jan 02, 2017 at 05:37:08PM +0100, Quentin Schulz wrote: >> [...] >> >> +static int axp20x_ac_power_probe(struct platform_device *pdev) >> +{ >

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-16 Thread Sebastian Reichel
Hi Quentin, The driver looks mostly fine. I do have a two comments, though. On Mon, Jan 02, 2017 at 05:37:08PM +0100, Quentin Schulz wrote: > [...] > > +static int axp20x_ac_power_probe(struct platform_device *pdev) > +{ > + static const char * const axp20x_irq_names[] = { "ACIN_PLUGIN", > +

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-08 Thread Jonathan Cameron
On 02/01/17 11:37, Quentin Schulz wrote: > The X-Powers AXP20X and AXP22X PMICs expose the status of AC power > supply. > > Moreover, the AXP20X can also expose the current current and voltage > values of the AC power supply. > > This adds the driver which exposes the status of the AC power suppl

Re: [PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-08 Thread Quentin Schulz
Hi Jonathan, On 07/01/2017 20:31, Jonathan Cameron wrote: > On 02/01/17 11:37, Quentin Schulz wrote: [...] >> +/* >> + * IIO framework gives mV but Power Supply framework gives µV. >> + */ > single line comment syntax throughout or we'll have to face a patch 'fi

[PATCH 08/22] power: supply: add AC power supply driver for AXP20X and AXP22X PMICs

2017-01-02 Thread Quentin Schulz
The X-Powers AXP20X and AXP22X PMICs expose the status of AC power supply. Moreover, the AXP20X can also expose the current current and voltage values of the AC power supply. This adds the driver which exposes the status of the AC power supply of the AXP20X and AXP22X PMICs. Signed-off-by: Quent