Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-26 Thread Samuel Ortiz
Hi Arnd, On Fri, Jan 25, 2013 at 10:44:08PM +, Arnd Bergmann wrote: > If the twl4030_write_script function gets called with > a zero length argument, its return value does not > get set. We know that all scripts have a nonzero > length, but returning an error in case they ever > do is

Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-26 Thread Samuel Ortiz
Hi Arnd, On Fri, Jan 25, 2013 at 10:44:08PM +, Arnd Bergmann wrote: If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably

[PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Arnd Bergmann
If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably appropriate. Without this patch, building omap2plus_defconfig results in:

Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Amit Kucheria
On Fri, Jan 25, 2013 at 2:14 PM, Arnd Bergmann wrote: > If the twl4030_write_script function gets called with > a zero length argument, its return value does not > get set. We know that all scripts have a nonzero > length, but returning an error in case they ever > do is probably appropriate. > >

Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Arnd Bergmann
On Friday 25 January 2013 15:25:03 Peter Ujfalusi wrote: > On 01/25/2013 03:14 PM, Arnd Bergmann wrote: > > If the twl4030_write_script function gets called with > > a zero length argument, its return value does not > > get set. We know that all scripts have a nonzero > > length, but returning an

Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Peter Ujfalusi
On 01/25/2013 03:14 PM, Arnd Bergmann wrote: > If the twl4030_write_script function gets called with > a zero length argument, its return value does not > get set. We know that all scripts have a nonzero > length, but returning an error in case they ever > do is probably appropriate. > > Without

[PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Arnd Bergmann
If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably appropriate. Without this patch, building omap2plus_defconfig results in:

[PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Arnd Bergmann
If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably appropriate. Without this patch, building omap2plus_defconfig results in:

Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Peter Ujfalusi
On 01/25/2013 03:14 PM, Arnd Bergmann wrote: If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably appropriate. Without this

Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Arnd Bergmann
On Friday 25 January 2013 15:25:03 Peter Ujfalusi wrote: On 01/25/2013 03:14 PM, Arnd Bergmann wrote: If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in

Re: [PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Amit Kucheria
On Fri, Jan 25, 2013 at 2:14 PM, Arnd Bergmann a...@arndb.de wrote: If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably

[PATCH 09/19] mfd/twl4030: don't warn about uninitialized return code

2013-01-25 Thread Arnd Bergmann
If the twl4030_write_script function gets called with a zero length argument, its return value does not get set. We know that all scripts have a nonzero length, but returning an error in case they ever do is probably appropriate. Without this patch, building omap2plus_defconfig results in: