Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Leizhen (ThunderTown)
On 2020/11/28 1:25, Arnaldo Carvalho de Melo wrote: > Em Fri, Nov 27, 2020 at 02:22:02PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu: >>> On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei wrote: > An appropriate return value should

Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 02:22:02PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu: > > On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei wrote: > > > An appropriate return value should be set on the failed path. > > > Reported-by: Hulk Robot

Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu: > Hello, > > On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei wrote: > > > > An appropriate return value should be set on the failed path. > > > > Reported-by: Hulk Robot > > Signed-off-by: Zhen Lei > > Acked-by: Namhyung Kim Thanks,

Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Jiri Olsa
On Tue, Nov 24, 2020 at 06:36:52PM +0800, Zhen Lei wrote: > An appropriate return value should be set on the failed path. > > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/builtin-diff.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Namhyung Kim
Hello, On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei wrote: > > An appropriate return value should be set on the failed path. > > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/builtin-diff.c | 4 +++- > 1 file changed, 3

Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-27 Thread Leizhen (ThunderTown)
Hi everybody: Can any one review it? On 2020/11/24 18:36, Zhen Lei wrote: > An appropriate return value should be set on the failed path. > > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- > tools/perf/builtin-diff.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

[PATCH 1/1] perf diff: fix error return value in __cmd_diff()

2020-11-24 Thread Zhen Lei
An appropriate return value should be set on the failed path. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- tools/perf/builtin-diff.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index