Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Tue, Jun 10, 2014 at 8:42 AM, Linus Torvalds wrote: > > Ok, I'll take your patch-series rather than the recent pull from Andy, > and pick up #2 that way too. Hmm. In fact, #2 doesn't apply cleanly. It's trivial to fix up, but rather than do that, the reject made me go "I'll just forward this

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Tue, Jun 10, 2014 at 5:50 AM, Eric Paris wrote: > > No, it's good to blame me. I was trying to deal with it as fast as I > could since I was already trying to ignore my computer before I got > married last weekend and took the last week off. I realized when I got > back yesterday you hadn't

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, 2014-06-09 at 16:36 -0700, Linus Torvalds wrote: > On Mon, Jun 9, 2014 at 3:56 PM, Andy Lutomirski wrote: > > > > In this particular case, it's my patch, and I've never sent you a pull > > request. I sort of assumed that secur...@kernel.org magically caused > > acknowledged fixes to end

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, 2014-06-09 at 16:36 -0700, Linus Torvalds wrote: On Mon, Jun 9, 2014 at 3:56 PM, Andy Lutomirski l...@amacapital.net wrote: In this particular case, it's my patch, and I've never sent you a pull request. I sort of assumed that secur...@kernel.org magically caused acknowledged

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Tue, Jun 10, 2014 at 5:50 AM, Eric Paris epa...@redhat.com wrote: No, it's good to blame me. I was trying to deal with it as fast as I could since I was already trying to ignore my computer before I got married last weekend and took the last week off. I realized when I got back yesterday

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Tue, Jun 10, 2014 at 8:42 AM, Linus Torvalds torva...@linux-foundation.org wrote: Ok, I'll take your patch-series rather than the recent pull from Andy, and pick up #2 that way too. Hmm. In fact, #2 doesn't apply cleanly. It's trivial to fix up, but rather than do that, the reject made me

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 09:04:16PM -0700, Andy Lutomirski wrote: > On Mon, Jun 9, 2014 at 7:57 PM, Greg KH wrote: > > On Mon, Jun 09, 2014 at 05:51:37PM -0700, Andy Lutomirski wrote: > >> [cc list trimmed, security@ added] > >> > >> On Mon, Jun 9, 2014 at 5:31 PM, Greg KH wrote: > >> > On Mon,

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 7:57 PM, Greg KH wrote: > On Mon, Jun 09, 2014 at 05:51:37PM -0700, Andy Lutomirski wrote: >> [cc list trimmed, security@ added] >> >> On Mon, Jun 9, 2014 at 5:31 PM, Greg KH wrote: >> > On Mon, Jun 09, 2014 at 07:35:57PM -0400, Josh Boyer wrote: >> >> On Mon, Jun 9, 2014

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 05:51:37PM -0700, Andy Lutomirski wrote: > [cc list trimmed, security@ added] > > On Mon, Jun 9, 2014 at 5:31 PM, Greg KH wrote: > > On Mon, Jun 09, 2014 at 07:35:57PM -0400, Josh Boyer wrote: > >> On Mon, Jun 9, 2014 at 6:46 PM, Greg KH wrote: > >> > > >> > But yes,

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

[cc list trimmed, security@ added] On Mon, Jun 9, 2014 at 5:31 PM, Greg KH wrote: > On Mon, Jun 09, 2014 at 07:35:57PM -0400, Josh Boyer wrote: >> On Mon, Jun 9, 2014 at 6:46 PM, Greg KH wrote: >> > >> > But yes, having something "real" might be good if the load gets higher, >> > right now it's

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 05:30:19PM -0700, Andy Lutomirski wrote: > On Mon, Jun 9, 2014 at 5:32 PM, Greg KH wrote: > > On Mon, Jun 09, 2014 at 03:55:20PM -0700, Andy Lutomirski wrote: > >> On Mon, Jun 9, 2014 at 3:46 PM, Greg KH wrote: > >> > On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 5:32 PM, Greg KH wrote: > On Mon, Jun 09, 2014 at 03:55:20PM -0700, Andy Lutomirski wrote: >> On Mon, Jun 9, 2014 at 3:46 PM, Greg KH wrote: >> > On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: >> >> On Mon, Jun 9, 2014 at 3:30 PM, Greg KH >> >> wrote:

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 03:55:20PM -0700, Andy Lutomirski wrote: > On Mon, Jun 9, 2014 at 3:46 PM, Greg KH wrote: > > On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: > >> On Mon, Jun 9, 2014 at 3:30 PM, Greg KH wrote: > >> > On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 07:35:57PM -0400, Josh Boyer wrote: > On Mon, Jun 9, 2014 at 6:46 PM, Greg KH wrote: > > On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: > >> On Mon, Jun 9, 2014 at 3:30 PM, Greg KH wrote: > >> > On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote:

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:56 PM, Andy Lutomirski wrote: > > In this particular case, it's my patch, and I've never sent you a pull > request. I sort of assumed that secur...@kernel.org magically caused > acknowledged fixes to end up in your tree. I'm not sure what I'm > supposed to do here. > >

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 6:46 PM, Greg KH wrote: > On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: >> On Mon, Jun 9, 2014 at 3:30 PM, Greg KH wrote: >> > On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: >> >> From: Andy Lutomirski >> >> >> >> Fixes an easy DoS and

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:53 PM, Linus Torvalds wrote: > On Mon, Jun 9, 2014 at 3:35 PM, Andy Lutomirski wrote: >> >> Hmm. It seems that it didn't make it into Linus' tree. Crap. > > I assume that if there is a maintainer who normally sends me stuff by > git, when I see patches in emails they

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:46 PM, Greg KH wrote: > On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: >> On Mon, Jun 9, 2014 at 3:30 PM, Greg KH wrote: >> > On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: >> >> From: Andy Lutomirski >> >> >> >> Fixes an easy DoS and

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:35 PM, Andy Lutomirski wrote: > > Hmm. It seems that it didn't make it into Linus' tree. Crap. I assume that if there is a maintainer who normally sends me stuff by git, when I see patches in emails they are just informational heads-ups about stuff that is being

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: > On Mon, Jun 9, 2014 at 3:30 PM, Greg KH wrote: > > On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: > >> From: Andy Lutomirski > >> > >> Fixes an easy DoS and possible information disclosure. > >> > >> This does

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:30 PM, Greg KH wrote: > On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: >> From: Andy Lutomirski >> >> Fixes an easy DoS and possible information disclosure. >> >> This does nothing about the broken state of x32 auditing. >> >> eparis: If the admin has

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: > From: Andy Lutomirski > > Fixes an easy DoS and possible information disclosure. > > This does nothing about the broken state of x32 auditing. > > eparis: If the admin has enabled auditd and has specifically loaded audit > rules.

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: From: Andy Lutomirski l...@amacapital.net Fixes an easy DoS and possible information disclosure. This does nothing about the broken state of x32 auditing. eparis: If the admin has enabled auditd and has specifically loaded audit

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:30 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: From: Andy Lutomirski l...@amacapital.net Fixes an easy DoS and possible information disclosure. This does nothing about the broken state of x32 auditing.

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:30 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: From: Andy Lutomirski l...@amacapital.net Fixes an easy DoS and possible information

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:35 PM, Andy Lutomirski l...@amacapital.net wrote: Hmm. It seems that it didn't make it into Linus' tree. Crap. I assume that if there is a maintainer who normally sends me stuff by git, when I see patches in emails they are just informational heads-ups about stuff

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:46 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:30 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: From: Andy

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:53 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Jun 9, 2014 at 3:35 PM, Andy Lutomirski l...@amacapital.net wrote: Hmm. It seems that it didn't make it into Linus' tree. Crap. I assume that if there is a maintainer who normally sends me stuff by

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 6:46 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:30 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, May 28, 2014 at 11:09:58PM -0400, Eric Paris wrote: From: Andy

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 3:56 PM, Andy Lutomirski l...@amacapital.net wrote: In this particular case, it's my patch, and I've never sent you a pull request. I sort of assumed that secur...@kernel.org magically caused acknowledged fixes to end up in your tree. I'm not sure what I'm supposed to

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 03:55:20PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:46 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:30 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, May

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 07:35:57PM -0400, Josh Boyer wrote: On Mon, Jun 9, 2014 at 6:46 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:30 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, May 28,

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 5:32 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 03:55:20PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:46 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 03:35:02PM -0700, Andy Lutomirski wrote: On Mon, Jun 9,

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 05:30:19PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 5:32 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 03:55:20PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 3:46 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

[cc list trimmed, security@ added] On Mon, Jun 9, 2014 at 5:31 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 07:35:57PM -0400, Josh Boyer wrote: On Mon, Jun 9, 2014 at 6:46 PM, Greg KH gre...@linuxfoundation.org wrote: But yes, having something real might be good if

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 05:51:37PM -0700, Andy Lutomirski wrote: [cc list trimmed, security@ added] On Mon, Jun 9, 2014 at 5:31 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 07:35:57PM -0400, Josh Boyer wrote: On Mon, Jun 9, 2014 at 6:46 PM, Greg KH

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 9, 2014 at 7:57 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 05:51:37PM -0700, Andy Lutomirski wrote: [cc list trimmed, security@ added] On Mon, Jun 9, 2014 at 5:31 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 07:35:57PM -0400,

Re: [PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

On Mon, Jun 09, 2014 at 09:04:16PM -0700, Andy Lutomirski wrote: On Mon, Jun 9, 2014 at 7:57 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Jun 09, 2014 at 05:51:37PM -0700, Andy Lutomirski wrote: [cc list trimmed, security@ added] On Mon, Jun 9, 2014 at 5:31 PM, Greg KH

[PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

From: Andy Lutomirski Fixes an easy DoS and possible information disclosure. This does nothing about the broken state of x32 auditing. eparis: If the admin has enabled auditd and has specifically loaded audit rules. This bug has been around since before git. Wow... Cc:

[PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

Fixes an easy DoS and possible information disclosure. This does nothing about the broken state of x32 auditing. Cc: sta...@vger.kernel.org Signed-off-by: Andy Lutomirski --- kernel/auditsc.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git

[PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

Fixes an easy DoS and possible information disclosure. This does nothing about the broken state of x32 auditing. Cc: sta...@vger.kernel.org Signed-off-by: Andy Lutomirski l...@amacapital.net --- kernel/auditsc.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-)

[PATCH 1/2] auditsc: audit_krule mask accesses need bounds checking

From: Andy Lutomirski l...@amacapital.net Fixes an easy DoS and possible information disclosure. This does nothing about the broken state of x32 auditing. eparis: If the admin has enabled auditd and has specifically loaded audit rules. This bug has been around since before git. Wow... Cc: