[PATCH 1/2] rtc: add rtc-m41t80 driver (take 3)

2007-06-28 Thread Atsushi Nemoto
This is a new-style i2c driver for ST M41T80 series RTC chip, derived from works by Alexander Bigga <[EMAIL PROTECTED]> who wrote the original rtc-m41txx.c based on drivers/i2c/chips/m41t00.c driver. This driver supports M41T8[0-4] and M41ST8[457]. The old m41t00 driver supports M41T00, M41T81 an

Re: [PATCH 1/2] rtc: add rtc-m41t80 driver

2007-06-28 Thread Atsushi Nemoto
On Mon, 25 Jun 2007 22:21:42 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > > Oh the variable should not be static! > > I will send updated patch. > > I'll fix it up. ... > > Are you going back to "take 1" patches? Why? > > Stupidity, apparently. Will restore the take2 patches. Thanks. I f

Re: [PATCH 1/2] rtc: add rtc-m41t80 driver

2007-06-25 Thread Andrew Morton
On Tue, 26 Jun 2007 14:15:36 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > On Mon, 25 Jun 2007 21:46:20 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > + const static struct m41t80_chip_info *chip; > > > > It's a bit weird that `chip' has static storage class here. Was that > >

Re: [PATCH 1/2] rtc: add rtc-m41t80 driver

2007-06-25 Thread Atsushi Nemoto
On Mon, 25 Jun 2007 21:46:20 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > > + const static struct m41t80_chip_info *chip; > > It's a bit weird that `chip' has static storage class here. Was that > deliberate? Oh the variable should not be static! I will send updated patch. BTW, I reveive

Re: [PATCH 1/2] rtc: add rtc-m41t80 driver

2007-06-25 Thread Andrew Morton
On Thu, 21 Jun 2007 02:09:34 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > This is a new-style i2c driver for ST M41T80 series RTC chip, derived > from works by Alexander Bigga <[EMAIL PROTECTED]> who wrote the original > rtc-m41txx.c based on drivers/i2c/chips/m41t00.c driver. > > Thi

Re: [rtc-linux] [PATCH 1/2] rtc: add rtc-m41t80 driver (take 2)

2007-06-22 Thread Alessandro Zummo
On Fri, 22 Jun 2007 22:13:20 +0900 (JST) Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > This is a new-style i2c driver for ST M41T80 series RTC chip, derived > from works by Alexander Bigga <[EMAIL PROTECTED]> who wrote the original > rtc-m41txx.c based on drivers/i2c/chips/m41t00.c driver. > > This

[PATCH 1/2] rtc: add rtc-m41t80 driver (take 2)

2007-06-22 Thread Atsushi Nemoto
This is a new-style i2c driver for ST M41T80 series RTC chip, derived from works by Alexander Bigga <[EMAIL PROTECTED]> who wrote the original rtc-m41txx.c based on drivers/i2c/chips/m41t00.c driver. This driver supports M41T8[0-4] and M41ST8[457]. The old m41t00 driver supports M41T00, M41T81 an

[PATCH 1/2] rtc: add rtc-m41t80 driver

2007-06-20 Thread Atsushi Nemoto
This is a new-style i2c driver for ST M41T80 series RTC chip, derived from works by Alexander Bigga <[EMAIL PROTECTED]> who wrote the original rtc-m41txx.c based on drivers/i2c/chips/m41t00.c driver. This driver supports M41T8[0-4] and M41ST8[457]. The old m41t00 driver supports M41T00, M41T81 an