Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2015-01-14 Thread Lai Jiangshan
On 01/14/2015 09:57 PM, Tejun Heo wrote: > Hello, Lai. > > On Wed, Jan 14, 2015 at 10:47:16AM +0800, Lai Jiangshan wrote: >>> Even if that involves slightly more code, that's the right thing to do at >>> this point. >> >> Right, but in currently, the workqueue will be the only user, and I don't

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2015-01-14 Thread Tejun Heo
Hello, Lai. On Wed, Jan 14, 2015 at 10:47:16AM +0800, Lai Jiangshan wrote: > > Even if that involves slightly more code, that's the right thing to do at > > this point. > > Right, but in currently, the workqueue will be the only user, and I don't > known > asking who to do it, so I may keep it

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2015-01-13 Thread Lai Jiangshan
On 01/13/2015 11:22 PM, Tejun Heo wrote: > Hello, > > On Tue, Jan 13, 2015 at 03:19:09PM +0800, Lai Jiangshan wrote: >> The Mapping of the *online* cpus to nodes is already maintained by numa code. >> >> What the workqueue needs is a special Mapping: >> The Mapping of the *possible* cpus to n

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2015-01-13 Thread Tejun Heo
Hello, On Tue, Jan 13, 2015 at 03:19:09PM +0800, Lai Jiangshan wrote: > The Mapping of the *online* cpus to nodes is already maintained by numa code. > > What the workqueue needs is a special Mapping: > The Mapping of the *possible* cpus to nodes > > But this mapping (if the numa code main

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2015-01-12 Thread Lai Jiangshan
On 12/26/2014 04:11 AM, Tejun Heo wrote: > On Wed, Dec 17, 2014 at 01:56:29PM +0900, Kamezawa Hiroyuki wrote: >> Let me correct my words. Main purpose of this patch 1/2 is handling a case >> "node disappers" after boot. >> And try to handle physicall node hotplug caes. >> >> Changes of cpu<->node

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2014-12-25 Thread Tejun Heo
On Wed, Dec 17, 2014 at 01:56:29PM +0900, Kamezawa Hiroyuki wrote: > Let me correct my words. Main purpose of this patch 1/2 is handling a case > "node disappers" after boot. > And try to handle physicall node hotplug caes. > > Changes of cpu<->node relationship at CPU_ONLINE is handled in patch

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2014-12-16 Thread Kamezawa Hiroyuki
(2014/12/17 12:22), Kamezawa Hiroyuki wrote: (2014/12/17 10:36), Lai Jiangshan wrote: On 12/17/2014 12:45 AM, Kamezawa Hiroyuki wrote: With node online/offline, cpu<->node relationship is established. Workqueue uses a info which was established at boot time but it may be changed by node hotplug

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2014-12-16 Thread Kamezawa Hiroyuki
(2014/12/17 10:36), Lai Jiangshan wrote: On 12/17/2014 12:45 AM, Kamezawa Hiroyuki wrote: With node online/offline, cpu<->node relationship is established. Workqueue uses a info which was established at boot time but it may be changed by node hotpluging. Once pool->node points to a stale node,

Re: [PATCH 1/2] workqueue: update numa affinity info at node hotplug

2014-12-16 Thread Lai Jiangshan
On 12/17/2014 12:45 AM, Kamezawa Hiroyuki wrote: > With node online/offline, cpu<->node relationship is established. > Workqueue uses a info which was established at boot time but > it may be changed by node hotpluging. > > Once pool->node points to a stale node, following allocation failure > hap

[PATCH 1/2] workqueue: update numa affinity info at node hotplug

2014-12-16 Thread Kamezawa Hiroyuki
With node online/offline, cpu<->node relationship is established. Workqueue uses a info which was established at boot time but it may be changed by node hotpluging. Once pool->node points to a stale node, following allocation failure happens. == SLUB: Unable to allocate memory on node 2 (gf