Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

Hi Ingo, Ingo Molnar wrote: > * Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > >>> - return 1; >>> + ret = 1; >> Here, "return 1;" is correct. After single step is done, preemption is >> enabled in post_kprobe_handler(). > > could you resend the fixed patch?

Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

* Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > > - return 1; > > + ret = 1; > > Here, "return 1;" is correct. After single step is done, preemption is > enabled in post_kprobe_handler(). could you resend the fixed patch? (instead of me fixing it up by hand

Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

* Masami Hiramatsu [EMAIL PROTECTED] wrote: - return 1; + ret = 1; Here, return 1; is correct. After single step is done, preemption is enabled in post_kprobe_handler(). could you resend the fixed patch? (instead of me fixing it up by hand - which

Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

Hi Ingo, Ingo Molnar wrote: * Masami Hiramatsu [EMAIL PROTECTED] wrote: - return 1; + ret = 1; Here, return 1; is correct. After single step is done, preemption is enabled in post_kprobe_handler(). could you resend the fixed patch? (instead of me

Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

Hi Masami Hiramatsu wrote: > Fix a preemption bug in kprobe_handler(). It has to call preempt_enable() > before returning. > I think this is critical on preemptive kernel. Sorry, this patch has a mistake. > > Signed-off-by: Masami Hiramatsu <[EMAIL PROTECTED]> > --- > arch/x86/kernel/kprobes.c

[PATCH 1/2] x86: fix kprobe_handler reenable preemption

Fix a preemption bug in kprobe_handler(). It has to call preempt_enable() before returning. I think this is critical on preemptive kernel. Signed-off-by: Masami Hiramatsu <[EMAIL PROTECTED]> --- arch/x86/kernel/kprobes.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index:

[PATCH 1/2] x86: fix kprobe_handler reenable preemption

Fix a preemption bug in kprobe_handler(). It has to call preempt_enable() before returning. I think this is critical on preemptive kernel. Signed-off-by: Masami Hiramatsu [EMAIL PROTECTED] --- arch/x86/kernel/kprobes.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index:

Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption

Hi Masami Hiramatsu wrote: Fix a preemption bug in kprobe_handler(). It has to call preempt_enable() before returning. I think this is critical on preemptive kernel. Sorry, this patch has a mistake. Signed-off-by: Masami Hiramatsu [EMAIL PROTECTED] --- arch/x86/kernel/kprobes.c |5