Hi Guenter,
On Sun, Sep 22, 2013 at 08:37:23PM -0700, Guenter Roeck wrote:
> On 09/21/2013 07:00 AM, Maxime Ripard wrote:
>
> [ ... ]
>
> >>+ /* assert cpu core reset */
> >>+ writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
> >>+ /* L1RSTDISABLE hold low */
> >>+ pwr_reg =
Hi,
On Mon, Sep 23, 2013 at 10:43:55PM +0800, cinifr wrote:
> > In which case this kernel patch needs instead to speak the bootloader
> > wakeup protocol instead of speaking to the h/w directly like you've done
> > here, right?
> >
> > Or is it possible for the bootloader to set these things up
On Mon, Sep 23, 2013 at 09:19:17PM +0300, Maxime Ripard wrote:
> Hi Guenter,
>
> On Sun, Sep 22, 2013 at 08:37:23PM -0700, Guenter Roeck wrote:
> > On 09/21/2013 07:00 AM, Maxime Ripard wrote:
> >
> > [ ... ]
> >
> > >>+ /* assert cpu core reset */
> > >>+ writel(0, sunxi7i_cc_base +
> In which case this kernel patch needs instead to speak the bootloader
> wakeup protocol instead of speaking to the h/w directly like you've done
> here, right?
>
> Or is it possible for the bootloader to set these things up and then put
> the CPU back to sleep such that it both retains any
On Sun, 2013-09-22 at 23:31 +0800, cinifr wrote:
>
>
> On Sunday, 22 September 2013, Ian Campbell wrote:
> > On Sun, 2013-09-22 at 20:21 +0800, Fan Rong wrote:
> >
> >> + /* Set boot addr */
> >> + paddr = virt_to_phys(sun7i_secondary_startup);
> >> + writel(paddr, sunxi7i_cc_base +
Hello,
On Sat, Sep 21, 2013 at 05:49:00PM -0500, Maxime Ripard wrote:
> On Sun, Sep 22, 2013 at 12:49:45AM +0800, cinifr wrote:
> > Thanks. I have modify my patch as you said.
> > It is in attachments. Maybe I remail the new patch?
>
> Yes, remail the whole serie and change the prefix to PATCHv3
Hello,
On Sat, Sep 21, 2013 at 05:49:00PM -0500, Maxime Ripard wrote:
On Sun, Sep 22, 2013 at 12:49:45AM +0800, cinifr wrote:
Thanks. I have modify my patch as you said.
It is in attachments. Maybe I remail the new patch?
Yes, remail the whole serie and change the prefix to PATCHv3 (you
On Sun, 2013-09-22 at 23:31 +0800, cinifr wrote:
On Sunday, 22 September 2013, Ian Campbell i...@hellion.org.uk wrote:
On Sun, 2013-09-22 at 20:21 +0800, Fan Rong wrote:
+ /* Set boot addr */
+ paddr = virt_to_phys(sun7i_secondary_startup);
+ writel(paddr,
In which case this kernel patch needs instead to speak the bootloader
wakeup protocol instead of speaking to the h/w directly like you've done
here, right?
Or is it possible for the bootloader to set these things up and then put
the CPU back to sleep such that it both retains any settings
On Mon, Sep 23, 2013 at 09:19:17PM +0300, Maxime Ripard wrote:
Hi Guenter,
On Sun, Sep 22, 2013 at 08:37:23PM -0700, Guenter Roeck wrote:
On 09/21/2013 07:00 AM, Maxime Ripard wrote:
[ ... ]
+ /* assert cpu core reset */
+ writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
+ /*
Hi,
On Mon, Sep 23, 2013 at 10:43:55PM +0800, cinifr wrote:
In which case this kernel patch needs instead to speak the bootloader
wakeup protocol instead of speaking to the h/w directly like you've done
here, right?
Or is it possible for the bootloader to set these things up and then
Hi Guenter,
On Sun, Sep 22, 2013 at 08:37:23PM -0700, Guenter Roeck wrote:
On 09/21/2013 07:00 AM, Maxime Ripard wrote:
[ ... ]
+ /* assert cpu core reset */
+ writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
+ /* L1RSTDISABLE hold low */
+ pwr_reg = readl(sunxi7i_cc_base +
On 09/21/2013 07:00 AM, Maxime Ripard wrote:
[ ... ]
+ /* assert cpu core reset */
+ writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
+ /* L1RSTDISABLE hold low */
+ pwr_reg = readl(sunxi7i_cc_base + AW_CPUCFG_GENCTL);
+ pwr_reg &= ~(1<
Use BIT(cpu) here. And
On 09/21/2013 07:00 AM, Maxime Ripard wrote:
[ ... ]
+ /* assert cpu core reset */
+ writel(0, sunxi7i_cc_base + CPUX_RESET_CTL(cpu));
+ /* L1RSTDISABLE hold low */
+ pwr_reg = readl(sunxi7i_cc_base + AW_CPUCFG_GENCTL);
+ pwr_reg = ~(1cpu);
+ writel(pwr_reg,
On Sun, Sep 22, 2013 at 12:49:45AM +0800, cinifr wrote:
> Thanks. I have modify my patch as you said.
> It is in attachments. Maybe I remail the new patch?
Yes, remail the whole serie and change the prefix to PATCHv3 (you can
use the --subject-prefix option of git format-patch to do so).
Maxime
On Sun, Sep 22, 2013 at 12:49:45AM +0800, cinifr wrote:
> Thanks. I have modify my patch as you said.
> It is in attachments. Maybe I remail the new patch?
Please don't attach patches (or if you do, ensure that they have an
inline disposition) as non-inline attachments can't be easily quoted
and
Thanks. I have modify my patch as you said.
It is in attachments. Maybe I remail the new patch?
0001-Add-smp-support-for-Allwinner-A20-sunxi-7i.patch
Description: Binary data
Hi Fan,
On Sat, Sep 21, 2013 at 09:05:14PM +0800, Fan Rong wrote:
> Signed-off-by: Fan Rong
I'd prefer a more verbose commit log here, and for the following patches
as well.
Usually, you detail what you're doing in the commit "title", and the
rest of the commit log would be why you're doing
On Sat, Sep 21, 2013 at 09:05:14PM +0800, Fan Rong wrote:
> @@ -0,0 +1,12 @@
> +#include
> +#include
> +
> +.section ".text.head", "ax"
Please use a tab instead of 8 spaces.
> + __CPUINIT
__CPUINIT has been removed.
> +
> +ENTRY(sun7i_secondary_startup)
> + msr cpsr_fsxc,
Signed-off-by: Fan Rong
---
arch/arm/mach-sunxi/Makefile | 2 +
arch/arm/mach-sunxi/headsmp.S | 12 ++
arch/arm/mach-sunxi/platform.h | 347 +
arch/arm/mach-sunxi/platsmp.c | 100
arch/arm/mach-sunxi/sunxi.c| 34 +++-
5 files
Signed-off-by: Fan Rong cin...@gmail.com
---
arch/arm/mach-sunxi/Makefile | 2 +
arch/arm/mach-sunxi/headsmp.S | 12 ++
arch/arm/mach-sunxi/platform.h | 347 +
arch/arm/mach-sunxi/platsmp.c | 100
arch/arm/mach-sunxi/sunxi.c| 34
On Sat, Sep 21, 2013 at 09:05:14PM +0800, Fan Rong wrote:
@@ -0,0 +1,12 @@
+#include linux/linkage.h
+#include linux/init.h
+
+.section .text.head, ax
Please use a tab instead of 8 spaces.
+ __CPUINIT
__CPUINIT has been removed.
+
+ENTRY(sun7i_secondary_startup)
+ msr
Hi Fan,
On Sat, Sep 21, 2013 at 09:05:14PM +0800, Fan Rong wrote:
Signed-off-by: Fan Rong cin...@gmail.com
I'd prefer a more verbose commit log here, and for the following patches
as well.
Usually, you detail what you're doing in the commit title, and the
rest of the commit log would be why
Thanks. I have modify my patch as you said.
It is in attachments. Maybe I remail the new patch?
0001-Add-smp-support-for-Allwinner-A20-sunxi-7i.patch
Description: Binary data
On Sun, Sep 22, 2013 at 12:49:45AM +0800, cinifr wrote:
Thanks. I have modify my patch as you said.
It is in attachments. Maybe I remail the new patch?
Please don't attach patches (or if you do, ensure that they have an
inline disposition) as non-inline attachments can't be easily quoted
and
On Sun, Sep 22, 2013 at 12:49:45AM +0800, cinifr wrote:
Thanks. I have modify my patch as you said.
It is in attachments. Maybe I remail the new patch?
Yes, remail the whole serie and change the prefix to PATCHv3 (you can
use the --subject-prefix option of git format-patch to do so).
Maxime
26 matches
Mail list logo
