Re: [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI

2020-07-02 Thread Dave Hansen
On 7/2/20 4:28 AM, Huang, Ying wrote: >> But, when the bit was removed (bit 0) the _other_ bit locations also >> got changed. That's not OK because the bit values are documented to >> mean one specific thing and users surely rely on them meaning that one >> thing and not changing from kernel to

Re: [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI

2020-07-02 Thread Huang, Ying
Dave Hansen writes: > From: Dave Hansen > > I went to go add a new RECLAIM_* mode for the zone_reclaim_mode > sysctl. Like a good kernel developer, I also went to go update the > documentation. I noticed that the bits in the documentation didn't > match the bits in the #defines. > > The VM

Re: [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI

2020-07-01 Thread David Rientjes
On Wed, 1 Jul 2020, Dave Hansen wrote: > > From: Dave Hansen > > I went to go add a new RECLAIM_* mode for the zone_reclaim_mode > sysctl. Like a good kernel developer, I also went to go update the > documentation. I noticed that the bits in the documentation didn't > match the bits in the

[PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI

2020-07-01 Thread Dave Hansen
From: Dave Hansen I went to go add a new RECLAIM_* mode for the zone_reclaim_mode sysctl. Like a good kernel developer, I also went to go update the documentation. I noticed that the bits in the documentation didn't match the bits in the #defines. The VM never explicitly checks the