Hi Marc,
Marc Dietrich wrote @ Sun, 10 Feb 2013 22:16:14 +0100:
> ah, ok - I just skipped the "also" in your sentence above. But still, the
> #ifdefs look strange to me and save only a few byte of code. Just me few
> cents.
What about the following as Arnd suggested[1]?
void __init
On Sunday 10 February 2013 13:20:49 Stephen Warren wrote:
> 1On 02/10/2013 10:28 AM, Marc Dietrich wrote:
> > On Friday 08 February 2013 10:09:10 Stephen Warren wrote:
> >> On 02/08/2013 05:29 AM, Marc Dietrich wrote:
> >>> Hiroshi,
> >>>
> >>> Am Freitag, 8. Februar 2013, 09:29:31 schrieb
1On 02/10/2013 10:28 AM, Marc Dietrich wrote:
> On Friday 08 February 2013 10:09:10 Stephen Warren wrote:
>> On 02/08/2013 05:29 AM, Marc Dietrich wrote:
>>> Hiroshi,
>>>
>>> Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
Refactored tegra{20,30,114}_init_early() so that we have
On Friday 08 February 2013 10:09:10 Stephen Warren wrote:
> On 02/08/2013 05:29 AM, Marc Dietrich wrote:
> > Hiroshi,
> >
> > Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
> >> Refactored tegra{20,30,114}_init_early() so that we have the unified
> >> tegra_init_early().
> >>
> >>
On Friday 08 February 2013 10:09:10 Stephen Warren wrote:
On 02/08/2013 05:29 AM, Marc Dietrich wrote:
Hiroshi,
Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
Refactored tegra{20,30,114}_init_early() so that we have the unified
tegra_init_early().
diff --git
1On 02/10/2013 10:28 AM, Marc Dietrich wrote:
On Friday 08 February 2013 10:09:10 Stephen Warren wrote:
On 02/08/2013 05:29 AM, Marc Dietrich wrote:
Hiroshi,
Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
Refactored tegra{20,30,114}_init_early() so that we have the unified
On Sunday 10 February 2013 13:20:49 Stephen Warren wrote:
1On 02/10/2013 10:28 AM, Marc Dietrich wrote:
On Friday 08 February 2013 10:09:10 Stephen Warren wrote:
On 02/08/2013 05:29 AM, Marc Dietrich wrote:
Hiroshi,
Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
Hi Marc,
Marc Dietrich marvi...@gmx.de wrote @ Sun, 10 Feb 2013 22:16:14 +0100:
ah, ok - I just skipped the also in your sentence above. But still, the
#ifdefs look strange to me and save only a few byte of code. Just me few
cents.
What about the following as Arnd suggested[1]?
void
On Friday 08 February 2013, Hiroshi Doyu wrote:
> > > +#if defined(CONFIG_ARCH_TEGRA_3x_SOC)
> >
> > how about using:
> >
> > #if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC)
> >
> > instead ?
>
> Why is IS_BUILTIN() prefered?
>
Inside of a function, if(IS_ENABLED(CONFIG_FOO)) or the respective
On Friday 08 February 2013, Hiroshi Doyu wrote:
+#if defined(CONFIG_ARCH_TEGRA_3x_SOC)
how about using:
#if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC)
instead ?
Why is IS_BUILTIN() prefered?
Inside of a function, if(IS_ENABLED(CONFIG_FOO)) or the respective IS_BUILTIN is
preferred
On 02/08/2013 05:29 AM, Marc Dietrich wrote:
> Hiroshi,
>
> Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
>> Refactored tegra{20,30,114}_init_early() so that we have the unified
>> tegra_init_early().
>> diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
>>
Hiroshi,
Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
> Refactored tegra{20,30,114}_init_early() so that we have the unified
> tegra_init_early().
>
> Signed-off-by: Hiroshi Doyu
[...]
> diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
> index
Hi Felipe,
Felipe Balbi wrote @ Fri, 8 Feb 2013 08:47:20 +0100:
> > +#if defined(CONFIG_ARCH_TEGRA_3x_SOC)
>
> how about using:
>
> #if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC)
>
> instead ?
Why is IS_BUILTIN() prefered?
> > -void tegra20_hotplug_init(void);
> > -void tegra30_hotplug_init(void);
Hi Felipe,
Felipe Balbi ba...@ti.com wrote @ Fri, 8 Feb 2013 08:47:20 +0100:
+#if defined(CONFIG_ARCH_TEGRA_3x_SOC)
how about using:
#if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC)
instead ?
Why is IS_BUILTIN() prefered?
-void tegra20_hotplug_init(void);
-void tegra30_hotplug_init(void);
Hiroshi,
Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
Refactored tegra{20,30,114}_init_early() so that we have the unified
tegra_init_early().
Signed-off-by: Hiroshi Doyu hd...@nvidia.com
[...]
diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
On 02/08/2013 05:29 AM, Marc Dietrich wrote:
Hiroshi,
Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu:
Refactored tegra{20,30,114}_init_early() so that we have the unified
tegra_init_early().
diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c
+void
Hi,
On Fri, Feb 08, 2013 at 09:29:31AM +0200, Hiroshi Doyu wrote:
> @@ -56,18 +56,21 @@ int tegra_cpu_disable(unsigned int cpu)
> return cpu == 0 ? -EPERM : 0;
> }
>
> -#ifdef CONFIG_ARCH_TEGRA_2x_SOC
> -extern void tegra20_hotplug_shutdown(void);
> -void __init
Refactored tegra{20,30,114}_init_early() so that we have the unified
tegra_init_early().
Signed-off-by: Hiroshi Doyu
---
arch/arm/mach-tegra/board-dt-tegra114.c |2 +-
arch/arm/mach-tegra/board-dt-tegra20.c |2 +-
arch/arm/mach-tegra/board-dt-tegra30.c |4 ++--
Refactored tegra{20,30,114}_init_early() so that we have the unified
tegra_init_early().
Signed-off-by: Hiroshi Doyu hd...@nvidia.com
---
arch/arm/mach-tegra/board-dt-tegra114.c |2 +-
arch/arm/mach-tegra/board-dt-tegra20.c |2 +-
arch/arm/mach-tegra/board-dt-tegra30.c |4 ++--
Hi,
On Fri, Feb 08, 2013 at 09:29:31AM +0200, Hiroshi Doyu wrote:
@@ -56,18 +56,21 @@ int tegra_cpu_disable(unsigned int cpu)
return cpu == 0 ? -EPERM : 0;
}
-#ifdef CONFIG_ARCH_TEGRA_2x_SOC
-extern void tegra20_hotplug_shutdown(void);
-void __init tegra20_hotplug_init(void)
20 matches
Mail list logo
