Re: [PATCH 1/4] clk: sunxi-ng: add support for the Allwinner A100 CCU

2020-06-03 Thread Chen-Yu Tsai
On Wed, Jun 3, 2020 at 5:42 PM 李扬韬 wrote: > > >> + /* Enable the lock bits on all PLLs */ > >> + for (i = 0; i < ARRAY_SIZE(pll_regs); i++) { > >> + val = readl(reg + pll_regs[i]); > >> + val |= BIT(29); > > > >Having a define for that would be nice here > > > >> + writel(val, reg +

回复:[PATCH 1/4] clk: sunxi-ng: add support for the Allwinner A100 CCU

2020-06-03 Thread 李扬韬
>> + /* Enable the lock bits on all PLLs */ >> + for (i = 0; i < ARRAY_SIZE(pll_regs); i++) { >> + val = readl(reg + pll_regs[i]); >> + val |= BIT(29); > >Having a define for that would be nice here > >> + writel(val, reg + pll_regs[i]); >> + } >> + >> + /* >> + * In order to pass the EMI

Re: [PATCH 1/4] clk: sunxi-ng: add support for the Allwinner A100 CCU

2020-05-22 Thread Maxime Ripard
Hi, On Fri, May 22, 2020 at 11:07:40AM +0800, Frank Lee wrote: > Add support for a100 in the sunxi-ng CCU framework. > > Signed-off-by: Frank Lee > --- > drivers/clk/sunxi-ng/Kconfig | 10 + > drivers/clk/sunxi-ng/Makefile |2 + >

[PATCH 1/4] clk: sunxi-ng: add support for the Allwinner A100 CCU

2020-05-21 Thread Frank Lee
Add support for a100 in the sunxi-ng CCU framework. Signed-off-by: Frank Lee --- drivers/clk/sunxi-ng/Kconfig | 10 + drivers/clk/sunxi-ng/Makefile |2 + drivers/clk/sunxi-ng/ccu-sun50i-a100-r.c | 206 +++ drivers/clk/sunxi-ng/ccu-sun50i-a100-r.h