Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-18 Thread Daniel Vetter
On Tue, Jul 18, 2017 at 2:47 PM, Laurent Pinchart wrote: > On Tuesday 18 Jul 2017 14:08:39 Daniel Vetter wrote: >> On Tue, Jul 18, 2017 at 01:14:12PM +0300, Laurent Pinchart wrote: >> > On Tuesday 18 Jul 2017 09:05:22 Maxime Ripard wrote: >> >> On Fri, Jul 14, 2017 at 02:43:12AM +0300, Laurent Pin

Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-18 Thread Laurent Pinchart
Hi Daniel, On Tuesday 18 Jul 2017 14:08:39 Daniel Vetter wrote: > On Tue, Jul 18, 2017 at 01:14:12PM +0300, Laurent Pinchart wrote: > > On Tuesday 18 Jul 2017 09:05:22 Maxime Ripard wrote: > >> On Fri, Jul 14, 2017 at 02:43:12AM +0300, Laurent Pinchart wrote: > >>> On Thursday 13 Jul 2017 16:41:13

Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-18 Thread Daniel Vetter
On Tue, Jul 18, 2017 at 01:14:12PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > On Tuesday 18 Jul 2017 09:05:22 Maxime Ripard wrote: > > On Fri, Jul 14, 2017 at 02:43:12AM +0300, Laurent Pinchart wrote: > > > On Thursday 13 Jul 2017 16:41:13 Maxime Ripard wrote: > > >> The current drm_atomic_he

Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-18 Thread Laurent Pinchart
Hi Maxime, On Tuesday 18 Jul 2017 09:05:22 Maxime Ripard wrote: > On Fri, Jul 14, 2017 at 02:43:12AM +0300, Laurent Pinchart wrote: > > On Thursday 13 Jul 2017 16:41:13 Maxime Ripard wrote: > >> The current drm_atomic_helper_commit_tail helper works only if the CRTC > >> is accessible, and documen

Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-18 Thread Maxime Ripard
Hi Laurent, On Fri, Jul 14, 2017 at 02:43:12AM +0300, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Thursday 13 Jul 2017 16:41:13 Maxime Ripard wrote: > > The current drm_atomic_helper_commit_tail helper works only if the CRTC is > > accessible, and documents an altern

Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-13 Thread Daniel Vetter
On Fri, Jul 14, 2017 at 1:43 AM, Laurent Pinchart wrote: >> Commit 52055bafa1ff ("drm: rcar-du: Move plane commit code from CRTC >> start to CRTC resume") changed the order of the plane commit and CRTC >> enable operations to accommodate the runtime PM requirements. However, >> this introduced cor

Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-13 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Thursday 13 Jul 2017 16:41:13 Maxime Ripard wrote: > The current drm_atomic_helper_commit_tail helper works only if the CRTC is > accessible, and documents an alternative implementation that is supposed to > be used if that happens. > > That implementation

Re: [PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-13 Thread Daniel Vetter
On Thu, Jul 13, 2017 at 04:41:13PM +0200, Maxime Ripard wrote: > The current drm_atomic_helper_commit_tail helper works only if the CRTC is > accessible, and documents an alternative implementation that is supposed to > be used if that happens. > > That implementation is then duplicated by some dr

[PATCH 1/4] drm/atomic: implement drm_atomic_helper_commit_tail for runtime_pm users

2017-07-13 Thread Maxime Ripard
The current drm_atomic_helper_commit_tail helper works only if the CRTC is accessible, and documents an alternative implementation that is supposed to be used if that happens. That implementation is then duplicated by some drivers. Instead of documenting it, let's implement an helper that all the