Re: [PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Yinghai Lu
On Tue, Mar 11, 2014 at 3:02 PM, Bjorn Helgaas wrote: > On Tue, Mar 11, 2014 at 3:39 PM, Yinghai Lu wrote: >> how about replacing that with: >> >> if (avail.start > avail.end) >> continue; >> >> so we do not need to go deep into allocate_resource() > > We could, but why

Re: [PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Bjorn Helgaas
On Tue, Mar 11, 2014 at 3:39 PM, Yinghai Lu wrote: > On Tue, Mar 11, 2014 at 10:42 AM, Bjorn Helgaas wrote: >> Paul reported that after f75b99d5a77d ("PCI: Enforce bus address limits in >> resource allocation") on a 32-bit kernel (CONFIG_PHYS_ADDR_T_64BIT not >> set), intel-gtt complained "can't

Re: [PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Yinghai Lu
On Tue, Mar 11, 2014 at 10:42 AM, Bjorn Helgaas wrote: > Paul reported that after f75b99d5a77d ("PCI: Enforce bus address limits in > resource allocation") on a 32-bit kernel (CONFIG_PHYS_ADDR_T_64BIT not > set), intel-gtt complained "can't ioremap flush page - no chipset > flushing". In

[PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Bjorn Helgaas
Paul reported that after f75b99d5a77d ("PCI: Enforce bus address limits in resource allocation") on a 32-bit kernel (CONFIG_PHYS_ADDR_T_64BIT not set), intel-gtt complained "can't ioremap flush page - no chipset flushing". In addition, other PCI resource allocations, e.g., for bridge windows,

[PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Bjorn Helgaas
Paul reported that after f75b99d5a77d (PCI: Enforce bus address limits in resource allocation) on a 32-bit kernel (CONFIG_PHYS_ADDR_T_64BIT not set), intel-gtt complained can't ioremap flush page - no chipset flushing. In addition, other PCI resource allocations, e.g., for bridge windows, failed.

Re: [PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Yinghai Lu
On Tue, Mar 11, 2014 at 10:42 AM, Bjorn Helgaas bhelg...@google.com wrote: Paul reported that after f75b99d5a77d (PCI: Enforce bus address limits in resource allocation) on a 32-bit kernel (CONFIG_PHYS_ADDR_T_64BIT not set), intel-gtt complained can't ioremap flush page - no chipset flushing.

Re: [PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Bjorn Helgaas
On Tue, Mar 11, 2014 at 3:39 PM, Yinghai Lu ying...@kernel.org wrote: On Tue, Mar 11, 2014 at 10:42 AM, Bjorn Helgaas bhelg...@google.com wrote: Paul reported that after f75b99d5a77d (PCI: Enforce bus address limits in resource allocation) on a 32-bit kernel (CONFIG_PHYS_ADDR_T_64BIT not set),

Re: [PATCH 1/5] PCI: Don't check resource_size() in pci_bus_alloc_resource()

2014-03-11 Thread Yinghai Lu
On Tue, Mar 11, 2014 at 3:02 PM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Mar 11, 2014 at 3:39 PM, Yinghai Lu ying...@kernel.org wrote: how about replacing that with: if (avail.start avail.end) continue; so we do not need to go deep into