Re: [PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver

2013-05-25 Thread Maxime Ripard
Hi Tomasz, On Sat, May 25, 2013 at 02:06:51PM +0200, Tomasz Figa wrote: > Hi Maxime, > > Overall the driver looks good, just some minor nitpicks inline. Thanks for the review! I'll fix the comments you had and send a new version. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel

Re: [PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver

2013-05-25 Thread Tomasz Figa
Hi Maxime, Overall the driver looks good, just some minor nitpicks inline. On Friday 03 of May 2013 11:17:45 Maxime Ripard wrote: > This patch implements a basic driver for the I2C host driver found on > the Allwinner A10, A13 and A31 SoCs. > > Notable missing feature is 10-bit addressing. > >

[PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver

2013-05-03 Thread Maxime Ripard
This patch implements a basic driver for the I2C host driver found on the Allwinner A10, A13 and A31 SoCs. Notable missing feature is 10-bit addressing. Signed-off-by: Maxime Ripard --- .../devicetree/bindings/i2c/i2c-sunxi.txt | 19 + drivers/i2c/busses/Kconfig

[PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver

2013-05-02 Thread Maxime Ripard
This patch implements a basic driver for the I2C host driver found on the Allwinner A10, A13 and A31 SoCs. Notable missing feature is 10-bit addressing. Signed-off-by: Maxime Ripard --- .../devicetree/bindings/i2c/i2c-sunxi.txt | 19 + drivers/i2c/busses/Kconfig