Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 09/22/2016 07:15 AM, David Rientjes wrote: > On Thu, 22 Sep 2016, zijun_hu wrote: > >>> We don't support inserting when va->va_start == tmp_va->va_end, plain and >>> simple. There's no reason to do so. NACK to the patch. >>> >> i am sorry i disagree with you because >> 1) in almost all

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 09/22/2016 07:15 AM, David Rientjes wrote: > On Thu, 22 Sep 2016, zijun_hu wrote: > >>> We don't support inserting when va->va_start == tmp_va->va_end, plain and >>> simple. There's no reason to do so. NACK to the patch. >>> >> i am sorry i disagree with you because >> 1) in almost all

Re: [RFC PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 09/21/2016 12:23 PM, zijun_hu wrote: > From: zijun_hu > > correct a few logic error for __insert_vmap_area() since the else > if condition is always true and meaningless > > in order to fix this issue, if vmap_area inserted is lower than one > on rbtree then walk around

Re: [RFC PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 09/21/2016 12:23 PM, zijun_hu wrote: > From: zijun_hu > > correct a few logic error for __insert_vmap_area() since the else > if condition is always true and meaningless > > in order to fix this issue, if vmap_area inserted is lower than one > on rbtree then walk around left branch; if

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 2016/9/22 7:15, David Rientjes wrote: > On Thu, 22 Sep 2016, zijun_hu wrote: > >>> We don't support inserting when va->va_start == tmp_va->va_end, plain and >>> simple. There's no reason to do so. NACK to the patch. >>> >> i am sorry i disagree with you because >> 1) in almost all context

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 2016/9/22 7:15, David Rientjes wrote: > On Thu, 22 Sep 2016, zijun_hu wrote: > >>> We don't support inserting when va->va_start == tmp_va->va_end, plain and >>> simple. There's no reason to do so. NACK to the patch. >>> >> i am sorry i disagree with you because >> 1) in almost all context

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On Thu, 22 Sep 2016, zijun_hu wrote: > > We don't support inserting when va->va_start == tmp_va->va_end, plain and > > simple. There's no reason to do so. NACK to the patch. > > > i am sorry i disagree with you because > 1) in almost all context of vmalloc, original logic treat the special

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On Thu, 22 Sep 2016, zijun_hu wrote: > > We don't support inserting when va->va_start == tmp_va->va_end, plain and > > simple. There's no reason to do so. NACK to the patch. > > > i am sorry i disagree with you because > 1) in almost all context of vmalloc, original logic treat the special

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 2016/9/22 6:45, David Rientjes wrote: > On Thu, 22 Sep 2016, zijun_hu wrote: > correct a few logic error for __insert_vmap_area() since the else if condition is always true and meaningless in order to fix this issue, if vmap_area inserted is lower than one on rbtree

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 2016/9/22 6:45, David Rientjes wrote: > On Thu, 22 Sep 2016, zijun_hu wrote: > correct a few logic error for __insert_vmap_area() since the else if condition is always true and meaningless in order to fix this issue, if vmap_area inserted is lower than one on rbtree

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On Thu, 22 Sep 2016, zijun_hu wrote: > >> correct a few logic error for __insert_vmap_area() since the else > >> if condition is always true and meaningless > >> > >> in order to fix this issue, if vmap_area inserted is lower than one > >> on rbtree then walk around left branch; if higher then

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On Thu, 22 Sep 2016, zijun_hu wrote: > >> correct a few logic error for __insert_vmap_area() since the else > >> if condition is always true and meaningless > >> > >> in order to fix this issue, if vmap_area inserted is lower than one > >> on rbtree then walk around left branch; if higher then

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 2016/9/22 5:10, David Rientjes wrote: > On Wed, 21 Sep 2016, zijun_hu wrote: > >> From: zijun_hu >> >> correct a few logic error for __insert_vmap_area() since the else >> if condition is always true and meaningless >> >> in order to fix this issue, if vmap_area inserted is

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On 2016/9/22 5:10, David Rientjes wrote: > On Wed, 21 Sep 2016, zijun_hu wrote: > >> From: zijun_hu >> >> correct a few logic error for __insert_vmap_area() since the else >> if condition is always true and meaningless >> >> in order to fix this issue, if vmap_area inserted is lower than one >>

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On Wed, 21 Sep 2016, zijun_hu wrote: > From: zijun_hu > > correct a few logic error for __insert_vmap_area() since the else > if condition is always true and meaningless > > in order to fix this issue, if vmap_area inserted is lower than one > on rbtree then walk around left

Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

On Wed, 21 Sep 2016, zijun_hu wrote: > From: zijun_hu > > correct a few logic error for __insert_vmap_area() since the else > if condition is always true and meaningless > > in order to fix this issue, if vmap_area inserted is lower than one > on rbtree then walk around left branch; if higher

[PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

From: zijun_hu correct a few logic error for __insert_vmap_area() since the else if condition is always true and meaningless in order to fix this issue, if vmap_area inserted is lower than one on rbtree then walk around left branch; if higher then right branch otherwise

[PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()

From: zijun_hu correct a few logic error for __insert_vmap_area() since the else if condition is always true and meaningless in order to fix this issue, if vmap_area inserted is lower than one on rbtree then walk around left branch; if higher then right branch otherwise intersects with the