On Thu, Mar 4, 2021 at 12:29 AM Linus Walleij wrote:
>
> Hi Brad,
>
> thanks for your patch!
>
> On Thu, Mar 4, 2021 at 4:42 AM Brad Larson wrote:
>
> > This GPIO driver is for the Pensando Elba SoC which
> > provides control of four chip selects on two SPI busses.
> >
> > Signed-off-by: Brad Lar
On Mon, Mar 29, 2021 at 4:19 AM Brad Larson wrote:
> On Sun, Mar 7, 2021 at 11:21 AM Andy Shevchenko
> wrote:
> > On Thu, Mar 4, 2021 at 4:40 PM Brad Larson wrote:
...
> > > +config GPIO_ELBA_SPICS
> > > + bool "Pensando Elba SPI chip-select"
> >
> > Can't it be a module? Why?
>
> All El
On Sun, Mar 7, 2021 at 11:21 AM Andy Shevchenko
wrote:
>
> On Thu, Mar 4, 2021 at 4:40 PM Brad Larson wrote:
> >
> > This GPIO driver is for the Pensando Elba SoC which
> > provides control of four chip selects on two SPI busses.
>
> > +config GPIO_ELBA_SPICS
> > + bool "Pensando Elba SPI c
On Thu, Mar 4, 2021 at 4:40 PM Brad Larson wrote:
>
> This GPIO driver is for the Pensando Elba SoC which
> provides control of four chip selects on two SPI busses.
I will try to avoid repeating otheris in their reviews, but my comments below.
...
> +config GPIO_ELBA_SPICS
> + bool "Pensa
Hi Brad,
On Thu, Mar 4, 2021 at 4:59 AM Brad Larson wrote:
> This GPIO driver is for the Pensando Elba SoC which
> provides control of four chip selects on two SPI busses.
>
> Signed-off-by: Brad Larson
Thanks for your patch!
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -241,
On 04/03/2021 04:41, Brad Larson wrote:
> This GPIO driver is for the Pensando Elba SoC which
> provides control of four chip selects on two SPI busses.
>
> Signed-off-by: Brad Larson
> ---
> drivers/gpio/Kconfig | 6 ++
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-e
> -Original Message-
> From: Brad Larson
> Sent: Wednesday, March 3, 2021 9:42 PM
> Subject: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control
.
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
...
> +config GPIO_ELBA_SPICS
> + bool &q
On Thu, Mar 4, 2021 at 10:10 AM Serge Semin wrote:
> On Thu, Mar 04, 2021 at 09:29:33AM +0100, Linus Walleij wrote:
> > > + * pin: 32| 10
> > > + * bit: 7--6--5--4|---3--2--1--0
> > > + * cs1 cs1_ov
Hello Linus,
I started reviewing from the DW APB SPI driver part of this series,
that's why I suggested to remove the CS callback from there seeing it
doesn't really differ much from the generic one. But after looking at
the dts file and in this driver I think that the alterations layout
needs to
Hi Brad,
thanks for your patch!
On Thu, Mar 4, 2021 at 4:42 AM Brad Larson wrote:
> This GPIO driver is for the Pensando Elba SoC which
> provides control of four chip selects on two SPI busses.
>
> Signed-off-by: Brad Larson
(...)
> +#include
Use this in new drivers:
#include
> + * pin:
This GPIO driver is for the Pensando Elba SoC which
provides control of four chip selects on two SPI busses.
Signed-off-by: Brad Larson
---
drivers/gpio/Kconfig | 6 ++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-elba-spics.c | 120 +
3 f
11 matches
Mail list logo