Re: [PATCH 2/2] module: deal with the failure of complete_formation

On Wed, 06 Jan 2016 09:48:42 +0800 "Zhang, Yanmin" wrote: > On 2016/1/6 9:29, Steven Rostedt wrote: > > On Wed, 06 Jan 2016 09:14:42 +0800 > > "Zhang, Yanmin" wrote: > > > > > >> It's a good idea although ftrace_module_init_fail might be complicated. > > How so? I posted the patch. All it

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On 2016/1/6 9:29, Steven Rostedt wrote: > On Wed, 06 Jan 2016 09:14:42 +0800 > "Zhang, Yanmin" wrote: > > >> It's a good idea although ftrace_module_init_fail might be complicated. > How so? I posted the patch. All it does is to call > ftrace_release_mod(), which will only remove pages that are

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On Wed, 06 Jan 2016 09:14:42 +0800 "Zhang, Yanmin" wrote: > It's a good idea although ftrace_module_init_fail might be complicated. How so? I posted the patch. All it does is to call ftrace_release_mod(), which will only remove pages that are included with the module. If the pages were not

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On 2016/1/6 9:01, Steven Rostedt wrote: > On Fri, 25 Dec 2015 15:03:13 +0800 > "Qiu, PeiyangX" wrote: > >> From: Qiu Peiyang >> >> complete_formation might fail. kernel need clean up >> ftrace records of the module. >> >> The patch fixes it by tuning the operation sequence in >>

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On Fri, 25 Dec 2015 15:03:13 +0800 "Qiu, PeiyangX" wrote: > From: Qiu Peiyang > > complete_formation might fail. kernel need clean up > ftrace records of the module. > > The patch fixes it by tuning the operation sequence in > complete_formation. After complete_formation checks >

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On Fri, 25 Dec 2015 15:03:13 +0800 "Qiu, PeiyangX" wrote: > From: Qiu Peiyang > > complete_formation might fail. kernel need clean up > ftrace records of the module. > > The patch fixes it by tuning the operation sequence in >

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On 2016/1/6 9:01, Steven Rostedt wrote: > On Fri, 25 Dec 2015 15:03:13 +0800 > "Qiu, PeiyangX" wrote: > >> From: Qiu Peiyang >> >> complete_formation might fail. kernel need clean up >> ftrace records of the module. >> >> The patch fixes it by

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On Wed, 06 Jan 2016 09:14:42 +0800 "Zhang, Yanmin" wrote: > It's a good idea although ftrace_module_init_fail might be complicated. How so? I posted the patch. All it does is to call ftrace_release_mod(), which will only remove pages that are included with the

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On 2016/1/6 9:29, Steven Rostedt wrote: > On Wed, 06 Jan 2016 09:14:42 +0800 > "Zhang, Yanmin" wrote: > > >> It's a good idea although ftrace_module_init_fail might be complicated. > How so? I posted the patch. All it does is to call > ftrace_release_mod(), which

Re: [PATCH 2/2] module: deal with the failure of complete_formation

On Wed, 06 Jan 2016 09:48:42 +0800 "Zhang, Yanmin" wrote: > On 2016/1/6 9:29, Steven Rostedt wrote: > > On Wed, 06 Jan 2016 09:14:42 +0800 > > "Zhang, Yanmin" wrote: > > > > > >> It's a good idea although ftrace_module_init_fail

[PATCH 2/2] module: deal with the failure of complete_formation

From: Qiu Peiyang complete_formation might fail. kernel need clean up ftrace records of the module. The patch fixes it by tuning the operation sequence in complete_formation. After complete_formation checks verify_export_symbols, call ftrace_module_init to init ftrace records. Signed-off-by:

[PATCH 2/2] module: deal with the failure of complete_formation

From: Qiu Peiyang complete_formation might fail. kernel need clean up ftrace records of the module. The patch fixes it by tuning the operation sequence in complete_formation. After complete_formation checks verify_export_symbols, call ftrace_module_init to init ftrace