Re: [PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max

2019-09-02 Thread kbuild test robot
Hi Peter, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc6 next-20190830] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max

2019-08-30 Thread Andy Shevchenko
On Fri, Aug 30, 2019 at 11:15:27PM +0800, Peter Cai wrote: > On Fri, Aug 30, 2019, 7:55 PM Andy Shevchenko < > andriy.shevche...@linux.intel.com> wrote: > > I guess most of these #ifdef:s makes code less readable for exchange of > saving > few bytes in the module footprint. > > Well since they

Re: [PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max

2019-08-30 Thread Peter Cai
On August 30, 2019 7:55:05 PM GMT+08:00, Andy Shevchenko wrote: >On Fri, Aug 30, 2019 at 08:00:24AM +0800, Peter Cai wrote: >> The firmware of GPD P2 Max could not handle panel resets although >code >> is present in DSDT. The kernel needs to take on this job instead, but >> the DSDT does not

Re: [PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max

2019-08-30 Thread Andy Shevchenko
On Fri, Aug 30, 2019 at 08:00:24AM +0800, Peter Cai wrote: > The firmware of GPD P2 Max could not handle panel resets although code > is present in DSDT. The kernel needs to take on this job instead, but > the DSDT does not provide _DSD, rendering kernel helpless when trying to > find the

[PATCH 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max

2019-08-29 Thread Peter Cai
The firmware of GPD P2 Max could not handle panel resets although code is present in DSDT. The kernel needs to take on this job instead, but the DSDT does not provide _DSD, rendering kernel helpless when trying to find the respective GPIO pins. Fortunately, this time GPD has proper DMI vendor /