Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts

2014-12-04 Thread Mark Brown
On Thu, Dec 04, 2014 at 09:00:35AM +, Andrew Jackson wrote: > On 12/03/14 17:25, Mark Brown wrote: > > On Wed, Dec 03, 2014 at 04:38:55PM +, Andrew Jackson wrote: > >>case SNDRV_PCM_TRIGGER_STOP: > >>case SNDRV_PCM_TRIGGER_SUSPEND: > >>case SNDRV_PCM_TRIGGER_PAUSE_PUSH: > >> -

Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts

2014-12-04 Thread Andrew Jackson
On 12/04/14 06:43, rajeev kumar wrote: > On Thu, Dec 4, 2014 at 12:10 PM, rajeev kumar > wrote: >> On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown wrote: >>> On Wed, Dec 03, 2014 at 04:38:55PM +, Andrew Jackson wrote: >>> case SNDRV_PCM_TRIGGER_STOP: case SNDRV_PCM_TRIGGER_S

Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts

2014-12-04 Thread Andrew Jackson
On 12/03/14 17:25, Mark Brown wrote: > On Wed, Dec 03, 2014 at 04:38:55PM +, Andrew Jackson wrote: > >> case SNDRV_PCM_TRIGGER_STOP: >> case SNDRV_PCM_TRIGGER_SUSPEND: >> case SNDRV_PCM_TRIGGER_PAUSE_PUSH: >> -dev->active--; >> +if (dev->active > 0) >> +

Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts

2014-12-03 Thread rajeev kumar
On Thu, Dec 4, 2014 at 12:10 PM, rajeev kumar wrote: > On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown wrote: >> On Wed, Dec 03, 2014 at 04:38:55PM +, Andrew Jackson wrote: >> >>> case SNDRV_PCM_TRIGGER_STOP: >>> case SNDRV_PCM_TRIGGER_SUSPEND: >>> case SNDRV_PCM_TRIGGER_PAUSE_P

Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts

2014-12-03 Thread rajeev kumar
On Wed, Dec 3, 2014 at 10:55 PM, Mark Brown wrote: > On Wed, Dec 03, 2014 at 04:38:55PM +, Andrew Jackson wrote: > >> case SNDRV_PCM_TRIGGER_STOP: >> case SNDRV_PCM_TRIGGER_SUSPEND: >> case SNDRV_PCM_TRIGGER_PAUSE_PUSH: >> - dev->active--; >> + if (dev

Re: [PATCH 2/5] ASoC: dwc: Don't allow negative use counts

2014-12-03 Thread Mark Brown
On Wed, Dec 03, 2014 at 04:38:55PM +, Andrew Jackson wrote: > case SNDRV_PCM_TRIGGER_STOP: > case SNDRV_PCM_TRIGGER_SUSPEND: > case SNDRV_PCM_TRIGGER_PAUSE_PUSH: > - dev->active--; > + if (dev->active > 0) > + dev->active--; How is

[PATCH 2/5] ASoC: dwc: Don't allow negative use counts

2014-12-03 Thread Andrew Jackson
Signed-off-by: Andrew Jackson --- sound/soc/dwc/designware_i2s.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c index 08f0229..f8946bd 100644 --- a/sound/soc/dwc/designware_i2s.c +++ b/sound/soc/dwc/desig