Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
On 03/04/2014 11:12 AM, Alexander Shiyan wrote: > Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi > : >> We can then remove the iounmap() calls from probe and remove. >> Since the driver requests the resources via index we can do the mem resource >> request within a for loop. >> >>

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
On 03/04/2014 11:12 AM, Alexander Shiyan wrote: > Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi > : >> We can then remove the iounmap() calls from probe and remove. >> Since the driver requests the resources via index we can do the mem resource >> request within a for loop. >> >>

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
On 03/04/2014 11:23 AM, Alexander Shiyan wrote: >>> - l3->l3_base[2] = ioremap(res->start, resource_size(res)); >>> - if (!l3->l3_base[2]) { >>> - dev_err(>dev, "ioremap failed\n"); >>> - ret = -ENOMEM; >>> - goto err2; >>> + l3->l3_base[i] =

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Alexander Shiyan
Вторник, 4 марта 2014, 13:12 +04:00 от Alexander Shiyan : > Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi > : > > We can then remove the iounmap() calls from probe and remove. > > Since the driver requests the resources via index we can do the mem resource > > request within a for loop.

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Alexander Shiyan
Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi : > We can then remove the iounmap() calls from probe and remove. > Since the driver requests the resources via index we can do the mem resource > request within a for loop. > > Signed-off-by: Peter Ujfalusi > Reviewed-by: Santosh Shilimkar

[PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource request within a for loop. Signed-off-by: Peter Ujfalusi Reviewed-by: Santosh Shilimkar --- drivers/bus/omap_l3_noc.c | 63

[PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource request within a for loop. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilimkar@ti ---

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Alexander Shiyan
Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi peter.ujfal...@ti.com: We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource request within a for loop. Signed-off-by: Peter Ujfalusi

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Alexander Shiyan
Вторник, 4 марта 2014, 13:12 +04:00 от Alexander Shiyan shc_w...@mail.ru: Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi peter.ujfal...@ti.com: We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
On 03/04/2014 11:23 AM, Alexander Shiyan wrote: - l3-l3_base[2] = ioremap(res-start, resource_size(res)); - if (!l3-l3_base[2]) { - dev_err(pdev-dev, ioremap failed\n); - ret = -ENOMEM; - goto err2; + l3-l3_base[i] =

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
On 03/04/2014 11:12 AM, Alexander Shiyan wrote: Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi peter.ujfal...@ti.com: We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource request within a for loop.

Re: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2014-03-04 Thread Peter Ujfalusi
On 03/04/2014 11:12 AM, Alexander Shiyan wrote: Вторник, 4 марта 2014, 11:01 +02:00 от Peter Ujfalusi peter.ujfal...@ti.com: We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource request within a for loop.

[PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2013-05-02 Thread Peter Ujfalusi
We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource request within a for loop. Signed-off-by: Peter Ujfalusi --- drivers/bus/omap_l3_noc.c | 63 +++ 1 file changed,

[PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap()

2013-05-02 Thread Peter Ujfalusi
We can then remove the iounmap() calls from probe and remove. Since the driver requests the resources via index we can do the mem resource request within a for loop. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/bus/omap_l3_noc.c | 63