Re: [PATCH 3/3] audit: clean up refcounting in audit-tree

2012-08-21 Thread Linus Torvalds
On Tue, Aug 21, 2012 at 12:03 PM, Miklos Szeredi wrote: > + /* > +* We are guaranteed to have at least one reference to the mark from > +* either the inode or the caller of fsnotify_destroy_mark(). > +*/ > + BUG_ON(atomic_read(>refcnt) < 1); I pulled, but

[PATCH 3/3] audit: clean up refcounting in audit-tree

2012-08-21 Thread Miklos Szeredi
From: Miklos Szeredi Drop the initial reference by fsnotify_init_mark early instead of audit_tree_freeing_mark() at destroy time. In the cases we destroy the mark before we drop the initial reference we need to get rid of the get_mark that balances the put_mark in audit_tree_freeing_mark().

[PATCH 3/3] audit: clean up refcounting in audit-tree

2012-08-21 Thread Miklos Szeredi
From: Miklos Szeredi mszer...@suse.cz Drop the initial reference by fsnotify_init_mark early instead of audit_tree_freeing_mark() at destroy time. In the cases we destroy the mark before we drop the initial reference we need to get rid of the get_mark that balances the put_mark in

Re: [PATCH 3/3] audit: clean up refcounting in audit-tree

2012-08-21 Thread Linus Torvalds
On Tue, Aug 21, 2012 at 12:03 PM, Miklos Szeredi mik...@szeredi.hu wrote: + /* +* We are guaranteed to have at least one reference to the mark from +* either the inode or the caller of fsnotify_destroy_mark(). +*/ + BUG_ON(atomic_read(entry-refcnt) 1); I

[PATCH 3/3] audit: clean up refcounting in audit-tree

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi Drop the initial reference by fsnotify_init_mark early instead of audit_tree_freeing_mark() at destroy time. In the cases we destroy the mark before we drop the initial reference we need to get rid of the get_mark that balances the put_mark in audit_tree_freeing_mark().

[PATCH 3/3] audit: clean up refcounting in audit-tree

2012-08-15 Thread Miklos Szeredi
From: Miklos Szeredi mszer...@suse.cz Drop the initial reference by fsnotify_init_mark early instead of audit_tree_freeing_mark() at destroy time. In the cases we destroy the mark before we drop the initial reference we need to get rid of the get_mark that balances the put_mark in

Re: [PATCH 3/3] audit: clean up refcounting in audit-tree

2012-07-11 Thread Miklos Szeredi
On Fri, 2012-07-06 at 13:51 -0400, Eric Paris wrote: > On Mon, 2012-06-25 at 19:46 +0200, Miklos Szeredi wrote: > > From: Miklos Szeredi > > > > Drop the initial reference by fsnotify_init_mark early instead of > > audit_tree_freeing_mark() at destroy time. > > > > In the cases we destroy the

Re: [PATCH 3/3] audit: clean up refcounting in audit-tree

2012-07-11 Thread Miklos Szeredi
On Fri, 2012-07-06 at 13:51 -0400, Eric Paris wrote: On Mon, 2012-06-25 at 19:46 +0200, Miklos Szeredi wrote: From: Miklos Szeredi mszer...@suse.cz Drop the initial reference by fsnotify_init_mark early instead of audit_tree_freeing_mark() at destroy time. In the cases we destroy

Re: [PATCH 3/3] audit: clean up refcounting in audit-tree

2012-07-06 Thread Eric Paris
On Mon, 2012-06-25 at 19:46 +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Drop the initial reference by fsnotify_init_mark early instead of > audit_tree_freeing_mark() at destroy time. > > In the cases we destroy the mark before we drop the initial reference we need > to > get rid of

Re: [PATCH 3/3] audit: clean up refcounting in audit-tree

2012-07-06 Thread Eric Paris
On Mon, 2012-06-25 at 19:46 +0200, Miklos Szeredi wrote: From: Miklos Szeredi mszer...@suse.cz Drop the initial reference by fsnotify_init_mark early instead of audit_tree_freeing_mark() at destroy time. In the cases we destroy the mark before we drop the initial reference we need to