Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 11:53:39AM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Tue, Jul 18, 2017 at 09:35:03AM +0200, Daniel Vetter wrote: > > On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard > > wrote: > > > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-20 Thread Daniel Vetter
On Thu, Jul 20, 2017 at 11:53:39AM +0200, Maxime Ripard wrote: > Hi Daniel, > > On Tue, Jul 18, 2017 at 09:35:03AM +0200, Daniel Vetter wrote: > > On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard > > wrote: > > > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: > > >> On Mon, Jul 17,

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-20 Thread Maxime Ripard
Hi Daniel, On Tue, Jul 18, 2017 at 09:35:03AM +0200, Daniel Vetter wrote: > On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard > wrote: > > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: > >> On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard > >>

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-20 Thread Maxime Ripard
Hi Daniel, On Tue, Jul 18, 2017 at 09:35:03AM +0200, Daniel Vetter wrote: > On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard > wrote: > > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: > >> On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard > >> wrote: > >> > On Fri, Jul 14, 2017 at

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-18 Thread Daniel Vetter
On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard wrote: > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: >> On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard >> wrote: >> > On Fri, Jul 14, 2017 at 04:56:01PM +0800,

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-18 Thread Daniel Vetter
On Tue, Jul 18, 2017 at 9:07 AM, Maxime Ripard wrote: > On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: >> On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard >> wrote: >> > On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote: >> >> Hi, >> >> >> >> On Thu, Jul 13, 2017 at 10:41

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-18 Thread Maxime Ripard
On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: > On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard > wrote: > > On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote: > >> Hi, > >> > >> On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard > >>

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-18 Thread Maxime Ripard
On Mon, Jul 17, 2017 at 02:57:19PM +0800, Chen-Yu Tsai wrote: > On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard > wrote: > > On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote: > >> Hi, > >> > >> On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard > >> wrote: > >> > In the earlier display

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-17 Thread Chen-Yu Tsai
On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard wrote: > On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard >> wrote: >> > In the earlier display engine

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-17 Thread Chen-Yu Tsai
On Mon, Jul 17, 2017 at 2:55 PM, Maxime Ripard wrote: > On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard >> wrote: >> > In the earlier display engine designs, any register access while a commit >> > is pending is

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-17 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard > wrote: > > In the earlier display engine designs, any register access while a commit > > is pending is forbidden. > > > > One of the

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-17 Thread Maxime Ripard
On Fri, Jul 14, 2017 at 04:56:01PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard > wrote: > > In the earlier display engine designs, any register access while a commit > > is pending is forbidden. > > > > One of the symptoms is that reading a register will

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-14 Thread Chen-Yu Tsai
Hi, On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard wrote: > In the earlier display engine designs, any register access while a commit > is pending is forbidden. > > One of the symptoms is that reading a register will return another, random, > register value

Re: [PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-14 Thread Chen-Yu Tsai
Hi, On Thu, Jul 13, 2017 at 10:41 PM, Maxime Ripard wrote: > In the earlier display engine designs, any register access while a commit > is pending is forbidden. > > One of the symptoms is that reading a register will return another, random, > register value which can lead to register

[PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-13 Thread Maxime Ripard
In the earlier display engine designs, any register access while a commit is pending is forbidden. One of the symptoms is that reading a register will return another, random, register value which can lead to register corruptions if we ever do a read/modify/write cycle. Signed-off-by: Maxime

[PATCH 4/4] drm/sun4i: make sure we don't have a commit pending

2017-07-13 Thread Maxime Ripard
In the earlier display engine designs, any register access while a commit is pending is forbidden. One of the symptoms is that reading a register will return another, random, register value which can lead to register corruptions if we ever do a read/modify/write cycle. Signed-off-by: Maxime