Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Masami Hiramatsu
On Thu, 6 Jul 2017 22:06:58 +0900 Stafford Horne wrote: > On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote: > > On Tue, 4 Jul 2017 15:38:55 +0900 > > Masami Hiramatsu wrote: > > > > > +local testlog=`mktemp

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Masami Hiramatsu
On Thu, 6 Jul 2017 22:06:58 +0900 Stafford Horne wrote: > On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote: > > On Tue, 4 Jul 2017 15:38:55 +0900 > > Masami Hiramatsu wrote: > > > > > +local testlog=`mktemp $LOG_DIR/${testname}-log.XX` > > > + else > > > +local

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Steven Rostedt
On Thu, 6 Jul 2017 22:06:58 +0900 Stafford Horne wrote: > On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote: > > On Tue, 4 Jul 2017 15:38:55 +0900 > > Masami Hiramatsu wrote: > > > > > +local testlog=`mktemp

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Steven Rostedt
On Thu, 6 Jul 2017 22:06:58 +0900 Stafford Horne wrote: > On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote: > > On Tue, 4 Jul 2017 15:38:55 +0900 > > Masami Hiramatsu wrote: > > > > > +local testlog=`mktemp $LOG_DIR/${testname}-log.XX` > > > + else > > > +local

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Stafford Horne
On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote: > On Tue, 4 Jul 2017 15:38:55 +0900 > Masami Hiramatsu wrote: > > > +local testlog=`mktemp $LOG_DIR/${testname}-log.XX` > > + else > > +local testlog=`/proc/self/fd/1` > > cute trick. Shouldn't

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Stafford Horne
On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote: > On Tue, 4 Jul 2017 15:38:55 +0900 > Masami Hiramatsu wrote: > > > +local testlog=`mktemp $LOG_DIR/${testname}-log.XX` > > + else > > +local testlog=`/proc/self/fd/1` > > cute trick. Shouldn't this be: local

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Masami Hiramatsu
On Wed, 5 Jul 2017 12:29:17 -0400 Steven Rostedt wrote: > On Wed, 5 Jul 2017 12:25:06 -0400 > Steven Rostedt wrote: > > > > > @@ -255,12 +262,18 @@ __run_test() { # testfile > > > # Run one test case > > > run_test() { # testfile > > >local

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-06 Thread Masami Hiramatsu
On Wed, 5 Jul 2017 12:29:17 -0400 Steven Rostedt wrote: > On Wed, 5 Jul 2017 12:25:06 -0400 > Steven Rostedt wrote: > > > > > @@ -255,12 +262,18 @@ __run_test() { # testfile > > > # Run one test case > > > run_test() { # testfile > > >local testname=`basename $1` > > > - local

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-05 Thread Steven Rostedt
On Wed, 5 Jul 2017 12:25:06 -0400 Steven Rostedt wrote: > > @@ -255,12 +262,18 @@ __run_test() { # testfile > > # Run one test case > > run_test() { # testfile > >local testname=`basename $1` > > - local testlog=`mktemp $LOG_DIR/${testname}-log.XX` > > + if [

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-05 Thread Steven Rostedt
On Wed, 5 Jul 2017 12:25:06 -0400 Steven Rostedt wrote: > > @@ -255,12 +262,18 @@ __run_test() { # testfile > > # Run one test case > > run_test() { # testfile > >local testname=`basename $1` > > - local testlog=`mktemp $LOG_DIR/${testname}-log.XX` > > + if [ "$LOG_FILE" ] ; then

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-05 Thread Steven Rostedt
On Tue, 4 Jul 2017 15:38:55 +0900 Masami Hiramatsu wrote: > Output logs only to console if "-" is given to --logdir > option. In this case, ftracetest doesn't record any log > on the disk, and all logs immediately shown (including > all command logs.) Since there is no

Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-05 Thread Steven Rostedt
On Tue, 4 Jul 2017 15:38:55 +0900 Masami Hiramatsu wrote: > Output logs only to console if "-" is given to --logdir > option. In this case, ftracetest doesn't record any log > on the disk, and all logs immediately shown (including > all command logs.) Since there is no "tee" in the middle > of

[PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-04 Thread Masami Hiramatsu
Output logs only to console if "-" is given to --logdir option. In this case, ftracetest doesn't record any log on the disk, and all logs immediately shown (including all command logs.) Since there is no "tee" in the middle of command and console, it outputs the log really soon. This option is

[PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"

2017-07-04 Thread Masami Hiramatsu
Output logs only to console if "-" is given to --logdir option. In this case, ftracetest doesn't record any log on the disk, and all logs immediately shown (including all command logs.) Since there is no "tee" in the middle of command and console, it outputs the log really soon. This option is