[PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

From: Borislav Petkov Save the regs set when we call __die() for the first time and print it in oops_end(). Signed-off-by: Borislav Petkov --- arch/x86/kernel/dumpstack.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff

[PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

From: Borislav Petkov Save the regs set when we call __die() for the first time and print it in oops_end(). Signed-off-by: Borislav Petkov --- arch/x86/kernel/dumpstack.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 06:45:29PM +0100, Borislav Petkov wrote: > > You're better off getting rid of the CR2 line from __show_regs(), > > because it can be dangerously confusing. It's not actually part of the > > saved register state at all, it's something entirely different. It's > > like

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 06:45:29PM +0100, Borislav Petkov wrote: > > You're better off getting rid of the CR2 line from __show_regs(), > > because it can be dangerously confusing. It's not actually part of the > > saved register state at all, it's something entirely different. It's > > like

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 10:22:29AM -0700, Linus Torvalds wrote: > The reason we do that > > printk(KERN_DEFAULT "CR2: %016lx\n", address); > > is because WE ARE NOT PRINTING OUT THE CURRENT CR2 REGISTER! Whoopsie! Doh, __show_regs() reads CR2 again and there's a big fat window

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 10:22:29AM -0700, Linus Torvalds wrote: > The reason we do that > > printk(KERN_DEFAULT "CR2: %016lx\n", address); > > is because WE ARE NOT PRINTING OUT THE CURRENT CR2 REGISTER! Whoopsie! Doh, __show_regs() reads CR2 again and there's a big fat window

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 10:22:29AM -0700, Linus Torvalds wrote: > On Fri, Mar 16, 2018 at 4:48 AM, Borislav Petkov wrote: > > On Thu, Mar 15, 2018 at 02:01:32PM -0500, Josh Poimboeuf wrote: > >> no_context() has the following line, right before it calls oops_end(): > >> > >>

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 10:22:29AM -0700, Linus Torvalds wrote: > On Fri, Mar 16, 2018 at 4:48 AM, Borislav Petkov wrote: > > On Thu, Mar 15, 2018 at 02:01:32PM -0500, Josh Poimboeuf wrote: > >> no_context() has the following line, right before it calls oops_end(): > >> > >> /* Executive

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 4:48 AM, Borislav Petkov wrote: > On Thu, Mar 15, 2018 at 02:01:32PM -0500, Josh Poimboeuf wrote: >> no_context() has the following line, right before it calls oops_end(): >> >> /* Executive summary in case the body of the oops scrolled away */ >>

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 4:48 AM, Borislav Petkov wrote: > On Thu, Mar 15, 2018 at 02:01:32PM -0500, Josh Poimboeuf wrote: >> no_context() has the following line, right before it calls oops_end(): >> >> /* Executive summary in case the body of the oops scrolled away */ >>

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 08:16:06AM -0500, Josh Poimboeuf wrote: > Yeah, sounds good to me. I think an earlier version of your patches > already printed the user space opcodes anyway. Right, which means it works already! :-P -- Regards/Gruss, Boris. Good mailing practices for 400: avoid

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 08:16:06AM -0500, Josh Poimboeuf wrote: > Yeah, sounds good to me. I think an earlier version of your patches > already printed the user space opcodes anyway. Right, which means it works already! :-P -- Regards/Gruss, Boris. Good mailing practices for 400: avoid

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 01:11:17PM +0100, Borislav Petkov wrote: > On Fri, Mar 16, 2018 at 07:01:12AM -0500, Josh Poimboeuf wrote: > > Hm, the "Code: Bad RIP value" will always be shown for syscall regs, > > which will probably cause some unnecessary confusion/worry. Should we > > just skip

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 01:11:17PM +0100, Borislav Petkov wrote: > On Fri, Mar 16, 2018 at 07:01:12AM -0500, Josh Poimboeuf wrote: > > Hm, the "Code: Bad RIP value" will always be shown for syscall regs, > > which will probably cause some unnecessary confusion/worry. Should we > > just skip

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 07:01:12AM -0500, Josh Poimboeuf wrote: > Hm, the "Code: Bad RIP value" will always be shown for syscall regs, > which will probably cause some unnecessary confusion/worry. Should we > just skip printing it for the "regs->ip < PAGE_OFFSET" case? How about we remove that

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 07:01:12AM -0500, Josh Poimboeuf wrote: > Hm, the "Code: Bad RIP value" will always be shown for syscall regs, > which will probably cause some unnecessary confusion/worry. Should we > just skip printing it for the "regs->ip < PAGE_OFFSET" case? How about we remove that

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 12:48:49PM +0100, Borislav Petkov wrote: > [ 29.046500] sysrq: SysRq : Trigger a crash > [ 29.048605] BUG: unable to handle kernel NULL pointer dereference at > > [ 29.051639] PGD 79afd067 P4D 79afd067 PUD 7a1a2067 PMD 0 > [ 29.052557] Oops: 0002

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Fri, Mar 16, 2018 at 12:48:49PM +0100, Borislav Petkov wrote: > [ 29.046500] sysrq: SysRq : Trigger a crash > [ 29.048605] BUG: unable to handle kernel NULL pointer dereference at > > [ 29.051639] PGD 79afd067 P4D 79afd067 PUD 7a1a2067 PMD 0 > [ 29.052557] Oops: 0002

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Thu, Mar 15, 2018 at 02:01:32PM -0500, Josh Poimboeuf wrote: > no_context() has the following line, right before it calls oops_end(): > > /* Executive summary in case the body of the oops scrolled away */ > printk(KERN_DEFAULT "CR2: %016lx\n", address); > > I think that line can

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Thu, Mar 15, 2018 at 02:01:32PM -0500, Josh Poimboeuf wrote: > no_context() has the following line, right before it calls oops_end(): > > /* Executive summary in case the body of the oops scrolled away */ > printk(KERN_DEFAULT "CR2: %016lx\n", address); > > I think that line can

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Thu, Mar 15, 2018 at 04:44:47PM +0100, Borislav Petkov wrote: > @@ -321,6 +323,9 @@ void oops_end(unsigned long flags, struct pt_regs *regs, > int signr) > raw_local_irq_restore(flags); > oops_exit(); > > + /* Executive summary in case the oops scrolled away */ > +

Re: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

On Thu, Mar 15, 2018 at 04:44:47PM +0100, Borislav Petkov wrote: > @@ -321,6 +323,9 @@ void oops_end(unsigned long flags, struct pt_regs *regs, > int signr) > raw_local_irq_restore(flags); > oops_exit(); > > + /* Executive summary in case the oops scrolled away */ > +

[PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

From: Borislav Petkov Save the regs set when we call __die() for the first time and print it in oops_end(). Signed-off-by: Borislav Petkov --- arch/x86/kernel/dumpstack.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-)

[PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary

From: Borislav Petkov Save the regs set when we call __die() for the first time and print it in oops_end(). Signed-off-by: Borislav Petkov --- arch/x86/kernel/dumpstack.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git