Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 26.03.2018 05:37, Dave Chinner wrote: > On Fri, Mar 23, 2018 at 03:39:53PM +0300, Kirill Tkhai wrote: >> On 23.03.2018 02:46, Dave Chinner wrote: >>> On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. >>> >>>

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 26.03.2018 05:37, Dave Chinner wrote: > On Fri, Mar 23, 2018 at 03:39:53PM +0300, Kirill Tkhai wrote: >> On 23.03.2018 02:46, Dave Chinner wrote: >>> On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. >>> >>>

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Fri, Mar 23, 2018 at 03:39:53PM +0300, Kirill Tkhai wrote: > On 23.03.2018 02:46, Dave Chinner wrote: > > On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: > >> Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. > > > > Oh, finally you tell me what the problem is

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Fri, Mar 23, 2018 at 03:39:53PM +0300, Kirill Tkhai wrote: > On 23.03.2018 02:46, Dave Chinner wrote: > > On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: > >> Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. > > > > Oh, finally you tell me what the problem is

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 23.03.2018 02:46, Dave Chinner wrote: > On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: >> Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. > > Oh, finally you tell me what the problem is that you're trying to > solve. I *asked this several times* and got no

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 23.03.2018 02:46, Dave Chinner wrote: > On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: >> Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. > > Oh, finally you tell me what the problem is that you're trying to > solve. I *asked this several times* and got no

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: > Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. Oh, finally you tell me what the problem is that you're trying to solve. I *asked this several times* and got no response. Thank you for wasting so much of my

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu, Mar 22, 2018 at 07:52:37PM +0300, Kirill Tkhai wrote: > Here is the problem I'm solving: https://lkml.org/lkml/2018/3/21/365. Oh, finally you tell me what the problem is that you're trying to solve. I *asked this several times* and got no response. Thank you for wasting so much of my

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 22.03.2018 08:01, Dave Chinner wrote: > On Wed, Mar 21, 2018 at 07:15:14PM +0300, Kirill Tkhai wrote: >> On 20.03.2018 17:34, Dave Chinner wrote: >>> On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: On 20.03.2018 03:18, Dave Chinner wrote: > On Mon, Mar 19, 2018 at

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 22.03.2018 08:01, Dave Chinner wrote: > On Wed, Mar 21, 2018 at 07:15:14PM +0300, Kirill Tkhai wrote: >> On 20.03.2018 17:34, Dave Chinner wrote: >>> On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: On 20.03.2018 03:18, Dave Chinner wrote: > On Mon, Mar 19, 2018 at

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Wed, Mar 21, 2018 at 07:15:14PM +0300, Kirill Tkhai wrote: > On 20.03.2018 17:34, Dave Chinner wrote: > > On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: > >> On 20.03.2018 03:18, Dave Chinner wrote: > >>> On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: > On

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Wed, Mar 21, 2018 at 07:15:14PM +0300, Kirill Tkhai wrote: > On 20.03.2018 17:34, Dave Chinner wrote: > > On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: > >> On 20.03.2018 03:18, Dave Chinner wrote: > >>> On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: > On

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 20.03.2018 17:34, Dave Chinner wrote: > On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: >> On 20.03.2018 03:18, Dave Chinner wrote: >>> On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: On 17.03.2018 00:39, Dave Chinner wrote: >>> Actually, it is fair, because:

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 20.03.2018 17:34, Dave Chinner wrote: > On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: >> On 20.03.2018 03:18, Dave Chinner wrote: >>> On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: On 17.03.2018 00:39, Dave Chinner wrote: >>> Actually, it is fair, because:

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: > On 20.03.2018 03:18, Dave Chinner wrote: > > On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: > >> On 17.03.2018 00:39, Dave Chinner wrote: > > Actually, it is fair, because: > > > > /* proportion the scan

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Tue, Mar 20, 2018 at 04:15:16PM +0300, Kirill Tkhai wrote: > On 20.03.2018 03:18, Dave Chinner wrote: > > On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: > >> On 17.03.2018 00:39, Dave Chinner wrote: > > Actually, it is fair, because: > > > > /* proportion the scan

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 20.03.2018 03:18, Dave Chinner wrote: > On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: >> On 17.03.2018 00:39, Dave Chinner wrote: >>> On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: On 16.03.2018 02:03, Dave Chinner wrote: > On Thu, Mar 15, 2018 at

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 20.03.2018 03:18, Dave Chinner wrote: > On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: >> On 17.03.2018 00:39, Dave Chinner wrote: >>> On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: On 16.03.2018 02:03, Dave Chinner wrote: > On Thu, Mar 15, 2018 at

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: > On 17.03.2018 00:39, Dave Chinner wrote: > > On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: > >> On 16.03.2018 02:03, Dave Chinner wrote: > >>> On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > On

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Mon, Mar 19, 2018 at 02:06:01PM +0300, Kirill Tkhai wrote: > On 17.03.2018 00:39, Dave Chinner wrote: > > On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: > >> On 16.03.2018 02:03, Dave Chinner wrote: > >>> On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > On

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 19.03.2018 14:06, Kirill Tkhai wrote: > On 17.03.2018 00:39, Dave Chinner wrote: >> On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: >>> On 16.03.2018 02:03, Dave Chinner wrote: On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > On 15.03.2018 20:49, Michal

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 19.03.2018 14:06, Kirill Tkhai wrote: > On 17.03.2018 00:39, Dave Chinner wrote: >> On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: >>> On 16.03.2018 02:03, Dave Chinner wrote: On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > On 15.03.2018 20:49, Michal

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 17.03.2018 00:39, Dave Chinner wrote: > On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: >> On 16.03.2018 02:03, Dave Chinner wrote: >>> On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: On 15.03.2018 20:49, Michal Hocko wrote: > On Thu 15-03-18 18:01:34,

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 17.03.2018 00:39, Dave Chinner wrote: > On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: >> On 16.03.2018 02:03, Dave Chinner wrote: >>> On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: On 15.03.2018 20:49, Michal Hocko wrote: > On Thu 15-03-18 18:01:34,

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: > On 16.03.2018 02:03, Dave Chinner wrote: > > On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > >> On 15.03.2018 20:49, Michal Hocko wrote: > >>> On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: >

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Fri, Mar 16, 2018 at 11:55:30AM +0300, Kirill Tkhai wrote: > On 16.03.2018 02:03, Dave Chinner wrote: > > On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > >> On 15.03.2018 20:49, Michal Hocko wrote: > >>> On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: >

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 16.03.2018 02:03, Dave Chinner wrote: > On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: >> On 15.03.2018 20:49, Michal Hocko wrote: >>> On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. So, it's called for memcg

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 16.03.2018 02:03, Dave Chinner wrote: > On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: >> On 15.03.2018 20:49, Michal Hocko wrote: >>> On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. So, it's called for memcg

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > On 15.03.2018 20:49, Michal Hocko wrote: > > On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: > >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > >> So, it's called for memcg reclaim too, e.g. this list is shrinked > >>

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu, Mar 15, 2018 at 10:28:43PM +0300, Kirill Tkhai wrote: > On 15.03.2018 20:49, Michal Hocko wrote: > > On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: > >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > >> So, it's called for memcg reclaim too, e.g. this list is shrinked > >>

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 15.03.2018 22:32, Michal Hocko wrote: > On Thu 15-03-18 22:28:43, Kirill Tkhai wrote: >> On 15.03.2018 20:49, Michal Hocko wrote: >>> On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. So, it's called for memcg reclaim too,

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 15.03.2018 22:32, Michal Hocko wrote: > On Thu 15-03-18 22:28:43, Kirill Tkhai wrote: >> On 15.03.2018 20:49, Michal Hocko wrote: >>> On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. So, it's called for memcg reclaim too,

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu 15-03-18 22:28:43, Kirill Tkhai wrote: > On 15.03.2018 20:49, Michal Hocko wrote: > > On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: > >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > >> So, it's called for memcg reclaim too, e.g. this list is shrinked > >>

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu 15-03-18 22:28:43, Kirill Tkhai wrote: > On 15.03.2018 20:49, Michal Hocko wrote: > > On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: > >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > >> So, it's called for memcg reclaim too, e.g. this list is shrinked > >>

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 15.03.2018 20:49, Michal Hocko wrote: > On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. >> So, it's called for memcg reclaim too, e.g. this list is shrinked >> disproportionality to another lists. >> >> This looks confusing, so I'm

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 15.03.2018 20:49, Michal Hocko wrote: > On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. >> So, it's called for memcg reclaim too, e.g. this list is shrinked >> disproportionality to another lists. >> >> This looks confusing, so I'm

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: > xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > So, it's called for memcg reclaim too, e.g. this list is shrinked > disproportionality to another lists. > > This looks confusing, so I'm reporting about this. > Consider this patch as

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu 15-03-18 18:01:34, Kirill Tkhai wrote: > xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > So, it's called for memcg reclaim too, e.g. this list is shrinked > disproportionality to another lists. > > This looks confusing, so I'm reporting about this. > Consider this patch as

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 15.03.2018 18:53, Darrick J. Wong wrote: > On Thu, Mar 15, 2018 at 06:01:34PM +0300, Kirill Tkhai wrote: >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. >> So, it's called for memcg reclaim too, e.g. this list is shrinked >> disproportionality to another lists. >> >> This

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On 15.03.2018 18:53, Darrick J. Wong wrote: > On Thu, Mar 15, 2018 at 06:01:34PM +0300, Kirill Tkhai wrote: >> xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. >> So, it's called for memcg reclaim too, e.g. this list is shrinked >> disproportionality to another lists. >> >> This

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu, Mar 15, 2018 at 06:01:34PM +0300, Kirill Tkhai wrote: > xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > So, it's called for memcg reclaim too, e.g. this list is shrinked > disproportionality to another lists. > > This looks confusing, so I'm reporting about this. >

Re: [PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

On Thu, Mar 15, 2018 at 06:01:34PM +0300, Kirill Tkhai wrote: > xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. > So, it's called for memcg reclaim too, e.g. this list is shrinked > disproportionality to another lists. > > This looks confusing, so I'm reporting about this. >

[PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. So, it's called for memcg reclaim too, e.g. this list is shrinked disproportionality to another lists. This looks confusing, so I'm reporting about this. Consider this patch as RFC. Signed-off-by: Kirill Tkhai

[PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim

xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg. So, it's called for memcg reclaim too, e.g. this list is shrinked disproportionality to another lists. This looks confusing, so I'm reporting about this. Consider this patch as RFC. Signed-off-by: Kirill Tkhai ---