Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

On Tue, Jul 04, 2017 at 03:25:45PM +0800, Yong wrote: > On Mon, 3 Jul 2017 13:25:21 +0200 > Maxime Ripard wrote: > > > Hi, > > > > On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote: > > > > > + select VIDEOBUF2_DMA_CONTIG > > > > > + select

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

On Tue, Jul 04, 2017 at 03:25:45PM +0800, Yong wrote: > On Mon, 3 Jul 2017 13:25:21 +0200 > Maxime Ripard wrote: > > > Hi, > > > > On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote: > > > > > + select VIDEOBUF2_DMA_CONTIG > > > > > + select REGMAP_MMIO > > > > > + ---help--- > >

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

On Mon, 3 Jul 2017 13:25:21 +0200 Maxime Ripard wrote: > Hi, > > On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote: > > > > + select VIDEOBUF2_DMA_CONTIG > > > > + select REGMAP_MMIO > > > > + ---help--- > > > > + Support for the

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

On Mon, 3 Jul 2017 13:25:21 +0200 Maxime Ripard wrote: > Hi, > > On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote: > > > > + select VIDEOBUF2_DMA_CONTIG > > > > + select REGMAP_MMIO > > > > + ---help--- > > > > + Support for the Allwinner Camera Sensor Interface

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Hi, On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote: > > > + select VIDEOBUF2_DMA_CONTIG > > > + select REGMAP_MMIO > > > + ---help--- > > > +Support for the Allwinner Camera Sensor Interface Controller. > > > > This controller is the same for all Allwinner SoC models? > > No. > I will

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Hi, On Mon, Jul 03, 2017 at 06:59:52PM +0800, Yong wrote: > > > + select VIDEOBUF2_DMA_CONTIG > > > + select REGMAP_MMIO > > > + ---help--- > > > +Support for the Allwinner Camera Sensor Interface Controller. > > > > This controller is the same for all Allwinner SoC models? > > No. > I will

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Hi Hans, Thanks for your review. On Mon, 3 Jul 2017 12:18:55 +0200 Hans Verkuil wrote: > Hi Yong Deng, > > Thanks for contributing this driver! > > First a high-level comment: you need to rebase this to the latest media_tree > master branch

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Hi Hans, Thanks for your review. On Mon, 3 Jul 2017 12:18:55 +0200 Hans Verkuil wrote: > Hi Yong Deng, > > Thanks for contributing this driver! > > First a high-level comment: you need to rebase this to the latest media_tree > master branch (https://git.linuxtv.org/media_tree.git/) since

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Hi Yong Deng, Thanks for contributing this driver! First a high-level comment: you need to rebase this to the latest media_tree master branch (https://git.linuxtv.org/media_tree.git/) since v4l2-of.h has been replaced by v4l2-fwnode.h. So this driver will not apply as-is. Also missing is a

Re: [PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Hi Yong Deng, Thanks for contributing this driver! First a high-level comment: you need to rebase this to the latest media_tree master branch (https://git.linuxtv.org/media_tree.git/) since v4l2-of.h has been replaced by v4l2-fwnode.h. So this driver will not apply as-is. Also missing is a

[PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface and CSI1 is used for parallel interface. This is not documented in datatsheet but by testing and guess. This patch implement a v4l2 framework driver for it. Currently, the driver only support the parallel interface.

[PATCH RFC 1/2] media: V3s: Add support for Allwinner CSI.

Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface and CSI1 is used for parallel interface. This is not documented in datatsheet but by testing and guess. This patch implement a v4l2 framework driver for it. Currently, the driver only support the parallel interface.