Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-20 Thread Maxime Ripard
On Tue, Aug 18, 2015 at 09:39:31AM -0700, Michael Turquette wrote: > > In my mind, the fact that we hand off the clock reference is a direct > > result to the clock being critical (or whatever name we want to call > > it). The hand off is a side effect, but the real information we want > > to carry

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-20 Thread Maxime Ripard
On Tue, Aug 18, 2015 at 09:33:56AM -0700, Michael Turquette wrote: > Quoting Maxime Ripard (2015-08-18 08:52:03) > > On Tue, Aug 11, 2015 at 11:58:27AM -0700, Michael Turquette wrote: > > > For example the whole big messy fuss over the DT bindings for the > > > simple-fb driver could have been avoi

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-18 Thread Maxime Ripard
Hi Mike, On Fri, Aug 07, 2015 at 12:09:30PM -0700, Michael Turquette wrote: > Some clocks are critical to system operation (e.g. cpu, memory, etc) and > should not be gated until a driver that knows best claims such a clock > and expressly gates that clock through the normal clk.h api. > > The ty

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-18 Thread Maxime Ripard
On Tue, Aug 11, 2015 at 11:58:27AM -0700, Michael Turquette wrote: > For example the whole big messy fuss over the DT bindings for the > simple-fb driver could have been avoided if this feature had existed > then. Not really, there was additional issues that would have prevented to use that in sim

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-12 Thread Lee Jones
On Wed, 12 Aug 2015, Geert Uytterhoeven wrote: > On Tue, Aug 11, 2015 at 8:17 PM, Lee Jones wrote: > >> I think that we can come up with a reasonable DT wrapper around the > >> flag. I will be ecstatic if we can agree that the meaning of the flag > >> can be tweaked just a bit to mean, "prevent t

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-12 Thread Geert Uytterhoeven
On Tue, Aug 11, 2015 at 8:17 PM, Lee Jones wrote: >> I think that we can come up with a reasonable DT wrapper around the >> flag. I will be ecstatic if we can agree that the meaning of the flag >> can be tweaked just a bit to mean, "prevent this critical clock from >> being disabled, as it was ena

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Michael Turquette wrote: > Quoting Lee Jones (2015-08-11 01:43:29) > > On Mon, 10 Aug 2015, Michael Turquette wrote: > > > Quoting Lee Jones (2015-08-10 07:48:11) > > > > On Fri, 07 Aug 2015, Michael Turquette wrote: > > > This series is solving the following problems: > > >

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Michael Turquette wrote: > Quoting Maxime Coquelin (2015-08-11 03:02:23) > > Hi Mike, > > > > On 08/11/2015 10:43 AM, Lee Jones wrote: > > > On Mon, 10 Aug 2015, Michael Turquette wrote: > > > > > >> > > >> > > >> ST's driver is an unfortunate case. All of the clock data was

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Michael Turquette wrote: > Quoting Geert Uytterhoeven (2015-08-11 03:11:05) > > Hi Maxime, > > > > On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin > > wrote: > > > How can we pass CLK_ENABLE_HAND_OFF flag to a specific clock on STi > > > platform? > > > > Add the flag to

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Michael Turquette
Quoting Maxime Coquelin (2015-08-11 03:02:23) > Hi Mike, > > On 08/11/2015 10:43 AM, Lee Jones wrote: > > On Mon, 10 Aug 2015, Michael Turquette wrote: > > > >> > >> > >> ST's driver is an unfortunate case. All of the clock data was shoved > >> into DT before we had a clue that doing so is a terri

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Michael Turquette
Quoting Geert Uytterhoeven (2015-08-11 03:11:05) > Hi Maxime, > > On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin > wrote: > > How can we pass CLK_ENABLE_HAND_OFF flag to a specific clock on STi > > platform? > > Add the flag to the relevant clocks in the C code, e.g. in > clk_register_flexgen

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Geert Uytterhoeven
On Tue, Aug 11, 2015 at 2:03 PM, Maxime Coquelin wrote: > On 08/11/2015 01:49 PM, Geert Uytterhoeven wrote: >> On Tue, Aug 11, 2015 at 1:41 PM, Maxime Coquelin >> wrote: >>> On 08/11/2015 01:36 PM, Maxime Coquelin wrote: On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: > On Tue, Aug 11,

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Lee Jones
On Tue, 11 Aug 2015, Geert Uytterhoeven wrote: > Hi Maxime, > > On Tue, Aug 11, 2015 at 1:41 PM, Maxime Coquelin > wrote: > > On 08/11/2015 01:36 PM, Maxime Coquelin wrote: > >> On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: > >>> On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin > >>> wrot

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Maxime Coquelin
On 08/11/2015 01:49 PM, Geert Uytterhoeven wrote: Hi Maxime, On Tue, Aug 11, 2015 at 1:41 PM, Maxime Coquelin wrote: On 08/11/2015 01:36 PM, Maxime Coquelin wrote: On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin wrote: How can we pass C

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Geert Uytterhoeven
Hi Maxime, On Tue, Aug 11, 2015 at 1:41 PM, Maxime Coquelin wrote: > On 08/11/2015 01:36 PM, Maxime Coquelin wrote: >> On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: >>> On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin >>> wrote: How can we pass CLK_ENABLE_HAND_OFF flag to a specific cl

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Maxime Coquelin
Sorry Geert, my reply has been cut: On 08/11/2015 01:36 PM, Maxime Coquelin wrote: Hi Geert, On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: Hi Maxime, On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin wrote: How can we pass CLK_ENABLE_HAND_OFF flag to a specific clock on STi platform? A

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Maxime Coquelin
Hi Geert, On 08/11/2015 12:11 PM, Geert Uytterhoeven wrote: Hi Maxime, On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin wrote: How can we pass CLK_ENABLE_HAND_OFF flag to a specific clock on STi platform? Add the flag to the relevant clocks in the C code, e.g. in clk_register_flexgen():

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Geert Uytterhoeven
Hi Maxime, On Tue, Aug 11, 2015 at 12:02 PM, Maxime Coquelin wrote: > How can we pass CLK_ENABLE_HAND_OFF flag to a specific clock on STi > platform? Add the flag to the relevant clocks in the C code, e.g. in clk_register_flexgen(): if (!strcmp(name, "clk-icn-cpu")) init

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Maxime Coquelin
Hi Mike, On 08/11/2015 10:43 AM, Lee Jones wrote: On Mon, 10 Aug 2015, Michael Turquette wrote: ST's driver is an unfortunate case. All of the clock data was shoved into DT before we had a clue that doing so is a terrible idea. I tend to agree, and wouldn't do it this way if we could rewri

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-11 Thread Lee Jones
On Mon, 10 Aug 2015, Michael Turquette wrote: > Quoting Lee Jones (2015-08-10 07:48:11) > > On Fri, 07 Aug 2015, Michael Turquette wrote: > > > > > Some clocks are critical to system operation (e.g. cpu, memory, etc) and > > > should not be gated until a driver that knows best claims such a clock

Re: [PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-10 Thread Lee Jones
On Fri, 07 Aug 2015, Michael Turquette wrote: > Some clocks are critical to system operation (e.g. cpu, memory, etc) and > should not be gated until a driver that knows best claims such a clock > and expressly gates that clock through the normal clk.h api. > > The typical way to handle this is fo

[PATCH RFC RFT 3/3] clk: introduce CLK_ENABLE_HAND_OFF flag

2015-08-07 Thread Michael Turquette
Some clocks are critical to system operation (e.g. cpu, memory, etc) and should not be gated until a driver that knows best claims such a clock and expressly gates that clock through the normal clk.h api. The typical way to handle this is for the clk driver or some other early code to call clk_pre