Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Thu, 2016-03-03 at 04:25 -0800, Joe Perches wrote: > My suggestion would be to add him and designate you and Adrian > as R: reviewers instead of M: maintainers like below. I think it is a little bit too early.

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Thu, 2016-03-03 at 04:25 -0800, Joe Perches wrote: > My suggestion would be to add him and designate you and Adrian > as R: reviewers instead of M: maintainers like below. I think it is a little bit too early.

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Thu, 2016-03-03 at 10:39 +0200, Artem Bityutskiy wrote: > On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote: > > > >   > >  UBI FILE SYSTEM (UBIFS) > > -M: Artem Bityutskiy > > -M: Adrian Hunter > > +M: Richard Weinberger > >  

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Thu, 2016-03-03 at 10:39 +0200, Artem Bityutskiy wrote: > On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote: > > > >   > >  UBI FILE SYSTEM (UBIFS) > > -M: Artem Bityutskiy > > -M: Adrian Hunter > > +M: Richard Weinberger > >  L: linux-...@lists.infradead.org > >  T: git

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote: >  >  UBI FILE SYSTEM (UBIFS) > -M: Artem Bityutskiy > -M: Adrian Hunter > +M: Richard Weinberger >  L: linux-...@lists.infradead.org >  T: git

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Wed, 2016-03-02 at 10:58 -0800, Joe Perches wrote: >  >  UBI FILE SYSTEM (UBIFS) > -M: Artem Bityutskiy > -M: Adrian Hunter > +M: Richard Weinberger >  L: linux-...@lists.infradead.org >  T: git git://git.infradead.org/ubifs-2.6.git >  W:

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Wed, 2016-03-02 at 22:24 +0100, Richard Weinberger wrote: > Am 02.03.2016 um 19:58 schrieb Joe Perches: [] > > For drivers/mtd/ubi, Artem is also a nominal maintainer, but > > last signed a patch in 2014. > > > > Likely the MAINTAINERS entry for UBI should be updated too. > > > > Maybe

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Wed, 2016-03-02 at 22:24 +0100, Richard Weinberger wrote: > Am 02.03.2016 um 19:58 schrieb Joe Perches: [] > > For drivers/mtd/ubi, Artem is also a nominal maintainer, but > > last signed a patch in 2014. > > > > Likely the MAINTAINERS entry for UBI should be updated too. > > > > Maybe

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

Joe, Am 02.03.2016 um 19:58 schrieb Joe Perches: > On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote: >> Am 02.03.2016 7:19 nachm. schrieb Joe Perches : >>> On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: The existing logging macros are fairly large and

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

Joe, Am 02.03.2016 um 19:58 schrieb Joe Perches: > On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote: >> Am 02.03.2016 7:19 nachm. schrieb Joe Perches : >>> On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: The existing logging macros are fairly large and converting the

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote: > Am 02.03.2016 7:19 nachm. schrieb Joe Perches : > > On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: > > > The existing logging macros are fairly large and converting the  > > > macros to functions make the

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Wed, 2016-03-02 at 19:46 +0100, Richard Weinberger wrote: > Am 02.03.2016 7:19 nachm. schrieb Joe Perches : > > On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: > > > The existing logging macros are fairly large and converting the  > > > macros to functions make the object code smaller.  >

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: > The existing logging macros are fairly large and converting the > macros to functions make the object code smaller. Artem and Adrian are the nominal maintainers for ubifs. Artem last had a sign-off on a ubifs patch 6 months ago and Adrian's

Re: [PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

On Tue, 2016-02-23 at 12:21 -0800, Joe Perches wrote: > The existing logging macros are fairly large and converting the > macros to functions make the object code smaller. Artem and Adrian are the nominal maintainers for ubifs. Artem last had a sign-off on a ubifs patch 6 months ago and Adrian's

[PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

The existing logging macros are fairly large and converting the macros to functions make the object code smaller. Use %pV and __builtin_return_address(0) as appropriate. Fix typo of sytem to system. $ size fs/ubifs/built-in.o* textdata bss dec hex filename 575831 309688

[PATCH V2] ubifs: Add logging functions for ubifs_msg, ubifs_err and ubifs_warn

The existing logging macros are fairly large and converting the macros to functions make the object code smaller. Use %pV and __builtin_return_address(0) as appropriate. Fix typo of sytem to system. $ size fs/ubifs/built-in.o* textdata bss dec hex filename 575831 309688