Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-06 Thread Paul Moore
On Wednesday, August 05, 2015 11:48:20 PM Richard Guy Briggs wrote: > Clean up a number of places were casted magic numbers are used to represent > unset inode and device numbers in preparation for the audit by executable > path patch set. > > Signed-off-by: Richard Guy Briggs > --- > v6: Change

Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-06 Thread Paul Moore
On Wednesday, August 05, 2015 11:40:34 PM Richard Guy Briggs wrote: > On 15/08/05, Paul Moore wrote: > > I suspect it was lost in the noise when I mentioned it on v4, but how > > about changing AUDIT_DEV_UNSET to "(dev_t)-1"? > > I saw your comment only after resubmitting. I'm fine either way.

Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-06 Thread Paul Moore
On Wednesday, August 05, 2015 11:48:20 PM Richard Guy Briggs wrote: Clean up a number of places were casted magic numbers are used to represent unset inode and device numbers in preparation for the audit by executable path patch set. Signed-off-by: Richard Guy Briggs r...@redhat.com ---

Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-06 Thread Paul Moore
On Wednesday, August 05, 2015 11:40:34 PM Richard Guy Briggs wrote: On 15/08/05, Paul Moore wrote: I suspect it was lost in the noise when I mentioned it on v4, but how about changing AUDIT_DEV_UNSET to (dev_t)-1? I saw your comment only after resubmitting. I'm fine either way. If it is

[PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Richard Guy Briggs
Clean up a number of places were casted magic numbers are used to represent unset inode and device numbers in preparation for the audit by executable path patch set. Signed-off-by: Richard Guy Briggs --- v6: Change dev macro cast from unsigned int to dev_t. v5: Move macros from

Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Richard Guy Briggs
On 15/08/05, Paul Moore wrote: > On Wednesday, August 05, 2015 04:19:09 PM Richard Guy Briggs wrote: > > Clean up a number of places were casted magic numbers are used to represent > > unset inode and device numbers in preparation for the audit by executable > > path patch set. > > > >

Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Paul Moore
On Wednesday, August 05, 2015 04:19:09 PM Richard Guy Briggs wrote: > Clean up a number of places were casted magic numbers are used to represent > unset inode and device numbers in preparation for the audit by executable > path patch set. > > Signed-off-by: Richard Guy Briggs > --- > v5: Move

[PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Richard Guy Briggs
Clean up a number of places were casted magic numbers are used to represent unset inode and device numbers in preparation for the audit by executable path patch set. Signed-off-by: Richard Guy Briggs --- v5: Move macros from include/uapi/linux/audit.h to include/linux/audit.h Use "unsigned

[PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Richard Guy Briggs
Clean up a number of places were casted magic numbers are used to represent unset inode and device numbers in preparation for the audit by executable path patch set. Signed-off-by: Richard Guy Briggs r...@redhat.com --- v5: Move macros from include/uapi/linux/audit.h to include/linux/audit.h

Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Paul Moore
On Wednesday, August 05, 2015 04:19:09 PM Richard Guy Briggs wrote: Clean up a number of places were casted magic numbers are used to represent unset inode and device numbers in preparation for the audit by executable path patch set. Signed-off-by: Richard Guy Briggs r...@redhat.com ---

[PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Richard Guy Briggs
Clean up a number of places were casted magic numbers are used to represent unset inode and device numbers in preparation for the audit by executable path patch set. Signed-off-by: Richard Guy Briggs r...@redhat.com --- v6: Change dev macro cast from unsigned int to dev_t. v5: Move macros from

Re: [PATCH V5] audit: use macros for unset inode and device values

2015-08-05 Thread Richard Guy Briggs
On 15/08/05, Paul Moore wrote: On Wednesday, August 05, 2015 04:19:09 PM Richard Guy Briggs wrote: Clean up a number of places were casted magic numbers are used to represent unset inode and device numbers in preparation for the audit by executable path patch set. Signed-off-by: