Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-11 Thread Sinan Kaya
On 8/10/2017 6:32 PM, Sinan Kaya wrote: >> Alex was concerned that pci_bus_read_dev_vendor_id() could return >> false ("no device here") with an ID value of ~0 for a functional VF >> [1]. >> >> I think that is indeed possible: >> >> - a VF that is ready will return 0x as both Vendor ID and

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-11 Thread Sinan Kaya
On 8/10/2017 6:32 PM, Sinan Kaya wrote: >> Alex was concerned that pci_bus_read_dev_vendor_id() could return >> false ("no device here") with an ID value of ~0 for a functional VF >> [1]. >> >> I think that is indeed possible: >> >> - a VF that is ready will return 0x as both Vendor ID and

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Sinan Kaya
On 8/10/2017 5:59 PM, Bjorn Helgaas wrote: > On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: >> Sporadic reset issues have been observed with Intel 750 NVMe drive by >> writing to the reset file in sysfs in a loop. The sequence of events >> observed is as follows: >> >> - perform a

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Sinan Kaya
On 8/10/2017 5:59 PM, Bjorn Helgaas wrote: > On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: >> Sporadic reset issues have been observed with Intel 750 NVMe drive by >> writing to the reset file in sysfs in a loop. The sequence of events >> observed is as follows: >> >> - perform a

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Sinan Kaya
On 8/10/2017 5:52 PM, Bjorn Helgaas wrote: > On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: >> Sporadic reset issues have been observed with Intel 750 NVMe drive by >> writing to the reset file in sysfs in a loop. The sequence of events >> observed is as follows: >> >> - perform a

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Sinan Kaya
On 8/10/2017 5:52 PM, Bjorn Helgaas wrote: > On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: >> Sporadic reset issues have been observed with Intel 750 NVMe drive by >> writing to the reset file in sysfs in a loop. The sequence of events >> observed is as follows: >> >> - perform a

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Bjorn Helgaas
On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: > Sporadic reset issues have been observed with Intel 750 NVMe drive by > writing to the reset file in sysfs in a loop. The sequence of events > observed is as follows: > > - perform a Function Level Reset (FLR) > - sleep up to 1000ms

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Bjorn Helgaas
On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: > Sporadic reset issues have been observed with Intel 750 NVMe drive by > writing to the reset file in sysfs in a loop. The sequence of events > observed is as follows: > > - perform a Function Level Reset (FLR) > - sleep up to 1000ms

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Bjorn Helgaas
On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: > Sporadic reset issues have been observed with Intel 750 NVMe drive by > writing to the reset file in sysfs in a loop. The sequence of events > observed is as follows: > > - perform a Function Level Reset (FLR) > - sleep up to 1000ms

Re: [PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-10 Thread Bjorn Helgaas
On Tue, Aug 08, 2017 at 08:57:24PM -0400, Sinan Kaya wrote: > Sporadic reset issues have been observed with Intel 750 NVMe drive by > writing to the reset file in sysfs in a loop. The sequence of events > observed is as follows: > > - perform a Function Level Reset (FLR) > - sleep up to 1000ms

[PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-08 Thread Sinan Kaya
Sporadic reset issues have been observed with Intel 750 NVMe drive by writing to the reset file in sysfs in a loop. The sequence of events observed is as follows: - perform a Function Level Reset (FLR) - sleep up to 1000ms total - read ~0 from PCI_COMMAND - warn that the device didn't return from

[PATCH V9 1/2] PCI: handle CRS returned by device after FLR

2017-08-08 Thread Sinan Kaya
Sporadic reset issues have been observed with Intel 750 NVMe drive by writing to the reset file in sysfs in a loop. The sequence of events observed is as follows: - perform a Function Level Reset (FLR) - sleep up to 1000ms total - read ~0 from PCI_COMMAND - warn that the device didn't return from