Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-14 Thread Maxime Ripard
On Sat, May 05, 2018 at 08:51:43AM +0200, Danny Milosavljevic wrote: > Hi Maxime, > > On Thu, 3 May 2018 16:46:19 +0200 > Maxime Ripard wrote: > > > Doesn't that mean that the controls will be shared between the right > > and left mixers now, which wasn't the case

Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-14 Thread Maxime Ripard
On Sat, May 05, 2018 at 08:51:43AM +0200, Danny Milosavljevic wrote: > Hi Maxime, > > On Thu, 3 May 2018 16:46:19 +0200 > Maxime Ripard wrote: > > > Doesn't that mean that the controls will be shared between the right > > and left mixers now, which wasn't the case before? > > Yes. However

Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-05 Thread Danny Milosavljevic
Hi Maxime, On Thu, 3 May 2018 16:46:19 +0200 Maxime Ripard wrote: > Doesn't that mean that the controls will be shared between the right > and left mixers now, which wasn't the case before? Yes. However Chen-Yu said that except for debugfs that cannot be observed by

Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-05 Thread Danny Milosavljevic
Hi Maxime, On Thu, 3 May 2018 16:46:19 +0200 Maxime Ripard wrote: > Doesn't that mean that the controls will be shared between the right > and left mixers now, which wasn't the case before? Yes. However Chen-Yu said that except for debugfs that cannot be observed by user space anyway. It's

Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-03 Thread Maxime Ripard
On Wed, May 02, 2018 at 11:07:55PM +0200, Danny Milosavljevic wrote: > Since it's now possible to have a DAPM mixer control with multiple channels, > use it to cut down the total number of controls. > > Keep "Left Mixer Left DAC Playback Switch" and "Right Mixer Right DAC Playback > Switch" name

Re: [PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-03 Thread Maxime Ripard
On Wed, May 02, 2018 at 11:07:55PM +0200, Danny Milosavljevic wrote: > Since it's now possible to have a DAPM mixer control with multiple channels, > use it to cut down the total number of controls. > > Keep "Left Mixer Left DAC Playback Switch" and "Right Mixer Right DAC Playback > Switch" name

[PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-02 Thread Danny Milosavljevic
Since it's now possible to have a DAPM mixer control with multiple channels, use it to cut down the total number of controls. Keep "Left Mixer Left DAC Playback Switch" and "Right Mixer Right DAC Playback Switch" name & layout the same as before for compatibility. Signed-off-by: Danny

[PATCH v14 3/8] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls

2018-05-02 Thread Danny Milosavljevic
Since it's now possible to have a DAPM mixer control with multiple channels, use it to cut down the total number of controls. Keep "Left Mixer Left DAC Playback Switch" and "Right Mixer Right DAC Playback Switch" name & layout the same as before for compatibility. Signed-off-by: Danny