Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-06 Thread Arnd Bergmann
On Monday 05 November 2012, Russell King - ARM Linux wrote: > On Mon, Nov 05, 2012 at 10:42:26PM +, Arnd Bergmann wrote: > > On Monday 05 November 2012, Rob Herring wrote: > > > But this should work: > > > > > > if (!handle_arch_irq) > > > handle_arch_irq = fpga_handle_irq; > > > > >

Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-05 Thread Russell King - ARM Linux
On Mon, Nov 05, 2012 at 10:42:26PM +, Arnd Bergmann wrote: > On Monday 05 November 2012, Rob Herring wrote: > > But this should work: > > > > if (!handle_arch_irq) > > handle_arch_irq = fpga_handle_irq; > > > > As long as the primary controller is always initialized first, this will >

Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-05 Thread Arnd Bergmann
On Monday 05 November 2012, Rob Herring wrote: > But this should work: > > if (!handle_arch_irq) > handle_arch_irq = fpga_handle_irq; > > As long as the primary controller is always initialized first, this will > work. This is guaranteed by DT of_irq_init, and you will probably have > oth

Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-05 Thread Rob Herring
On 11/02/2012 07:15 AM, Russell King - ARM Linux wrote: > On Thu, Nov 01, 2012 at 11:20:10PM +0100, Thomas Petazzoni wrote: >> Linus, >> >> On Thu, 1 Nov 2012 22:28:49 +0100, Linus Walleij wrote: >> >>> +void fpga_handle_irq(struct pt_regs *regs); >> >> This function does not need to be exposed in

Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-02 Thread Russell King - ARM Linux
On Thu, Nov 01, 2012 at 11:20:10PM +0100, Thomas Petazzoni wrote: > Linus, > > On Thu, 1 Nov 2012 22:28:49 +0100, Linus Walleij wrote: > > > +void fpga_handle_irq(struct pt_regs *regs); > > This function does not need to be exposed in a public header: as > proposed for the bcm2835 and armada-37

Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-01 Thread Thomas Petazzoni
Linus, On Thu, 1 Nov 2012 22:28:49 +0100, Linus Walleij wrote: > +void fpga_handle_irq(struct pt_regs *regs); This function does not need to be exposed in a public header: as proposed for the bcm2835 and armada-370-xp IRQ controller drivers, the driver should directly do handle_arch_irq = fpga_

[PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-01 Thread Linus Walleij
This moves the Versatile FPGA interrupt controller driver, used in the Integrator/AP, Integrator/CP and some Versatile boards, out of arch/arm/plat-versatile and down to drivers/irqchip where we have consensus that such drivers belong. The header file is consequently moved to . Signed-off-by: Linu