> > I don't think it is a blocker in any way and you may choose to ignore
> > it as well.
>
> That is alright, Sachin. I will make this change from home. Perhaps,
> it is wise anyhow to wait for more feedback, like e.g. from Lee, etc.
It's fine, just fixup and resend.
--
Lee Jones
Linaro
On Tue, Feb 11, 2014 at 11:42 AM, Sachin Kamat wrote:
> On 11 February 2014 17:09, Laszlo Papp wrote:
>> On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat
>> wrote:
>>> On 11 February 2014 15:40, Laszlo Papp wrote:
>>> [snip]
+
+struct max665x_dev {
+ struct
On 11 February 2014 17:09, Laszlo Papp wrote:
> On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat
> wrote:
>> On 11 February 2014 15:40, Laszlo Papp wrote:
>> [snip]
>>> +
>>> +struct max665x_dev {
>>> + struct device *dev;
>>> + struct mutex iolock;
>>> +
On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat wrote:
> On 11 February 2014 15:40, Laszlo Papp wrote:
> [snip]
>> +
>> +struct max665x_dev {
>> + struct device *dev;
>> + struct mutex iolock;
>> +
>> + struct i2c_client *i2c;
>> + struct
On 11 February 2014 15:40, Laszlo Papp wrote:
[snip]
> +
> +struct max665x_dev {
> + struct device *dev;
> + struct mutex iolock;
> +
> + struct i2c_client *i2c;
> + struct regmap *map;
> +
> + int type;
>>> [snip]
+
+struct max665x_dev {
+ struct device *dev;
+ struct mutex iolock;
+
+ struct i2c_client *i2c;
+ struct regmap *map;
+
+ int type;
>>>
>>> Unnecessary extra lines above could be removed.
>>
>> I prefer it
[snip]
+
+struct max665x_dev {
+ struct device *dev;
+ struct mutex iolock;
+
+ struct i2c_client *i2c;
+ struct regmap *map;
+
+ int type;
Unnecessary extra lines above could be removed.
I prefer it that way, but I will remove the two extra lines as
On 11 February 2014 15:40, Laszlo Papp lp...@kde.org wrote:
[snip]
+
+struct max665x_dev {
+ struct device *dev;
+ struct mutex iolock;
+
+ struct i2c_client *i2c;
+ struct regmap *map;
+
+ int type;
Unnecessary extra lines above could be removed.
I
On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
On 11 February 2014 15:40, Laszlo Papp lp...@kde.org wrote:
[snip]
+
+struct max665x_dev {
+ struct device *dev;
+ struct mutex iolock;
+
+ struct i2c_client *i2c;
+ struct regmap
On 11 February 2014 17:09, Laszlo Papp lp...@kde.org wrote:
On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat sachin.ka...@linaro.org
wrote:
On 11 February 2014 15:40, Laszlo Papp lp...@kde.org wrote:
[snip]
+
+struct max665x_dev {
+ struct device *dev;
+ struct mutex iolock;
+
On Tue, Feb 11, 2014 at 11:42 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
On 11 February 2014 17:09, Laszlo Papp lp...@kde.org wrote:
On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat sachin.ka...@linaro.org
wrote:
On 11 February 2014 15:40, Laszlo Papp lp...@kde.org wrote:
[snip]
+
I don't think it is a blocker in any way and you may choose to ignore
it as well.
That is alright, Sachin. I will make this change from home. Perhaps,
it is wise anyhow to wait for more feedback, like e.g. from Lee, etc.
It's fine, just fixup and resend.
--
Lee Jones
Linaro
On Mon, Feb 10, 2014 at 3:20 PM, Sachin Kamat wrote:
> On 10 February 2014 17:51, Lee Jones wrote:
>>> > +#include
>>> > +#include
>>> > +#include
>>> > +#include
>>>
>>> Please arrange these alphabetically.
>>
>> Why?
>
> 1. It makes it easier to avoid adding duplicate includes.
> 2. Code
> >> > +#include
> >> > +#include
> >> > +#include
> >> > +#include
> >>
> >> Please arrange these alphabetically.
> >
> > Why?
>
> 1. It makes it easier to avoid adding duplicate includes.
> 2. Code looks more ordered/organized.
> 3. Prevents further clean up patches arranging them so :)
I
On 10 February 2014 18:48, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 12:02 PM, Sachin Kamat
> wrote:
>> Hi Laszlo,
>>
>> If you are considering re-spinning this patch based on Lee's comments, please
>> also consider my comments inline.
>
> Hi, sure, thanks.
>
>> On 8 February 2014 17:03,
On 10 February 2014 17:51, Lee Jones wrote:
>> > +#include
>> > +#include
>> > +#include
>> > +#include
>>
>> Please arrange these alphabetically.
>
> Why?
1. It makes it easier to avoid adding duplicate includes.
2. Code looks more ordered/organized.
3. Prevents further clean up patches
> > +#include
> > +#include
> > +#include
> > +#include
>
> Please arrange these alphabetically.
Why?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the
Hi Laszlo,
If you are considering re-spinning this patch based on Lee's comments, please
also consider my comments inline.
On 8 February 2014 17:03, Laszlo Papp wrote:
> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
> chip includes fan-speed regulators and monitors, GPIO,
Hi Laszlo,
If you are considering re-spinning this patch based on Lee's comments, please
also consider my comments inline.
On 8 February 2014 17:03, Laszlo Papp lp...@kde.org wrote:
MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
chip includes fan-speed regulators and
+#include linux/device.h
+#include linux/mfd/core.h
+#include linux/module.h
+#include linux/i2c.h
Please arrange these alphabetically.
Why?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter |
On 10 February 2014 17:51, Lee Jones lee.jo...@linaro.org wrote:
+#include linux/device.h
+#include linux/mfd/core.h
+#include linux/module.h
+#include linux/i2c.h
Please arrange these alphabetically.
Why?
1. It makes it easier to avoid adding duplicate includes.
2. Code looks more
On 10 February 2014 18:48, Laszlo Papp lp...@kde.org wrote:
On Mon, Feb 10, 2014 at 12:02 PM, Sachin Kamat sachin.ka...@linaro.org
wrote:
Hi Laszlo,
If you are considering re-spinning this patch based on Lee's comments, please
also consider my comments inline.
Hi, sure, thanks.
On 8
+#include linux/device.h
+#include linux/mfd/core.h
+#include linux/module.h
+#include linux/i2c.h
Please arrange these alphabetically.
Why?
1. It makes it easier to avoid adding duplicate includes.
2. Code looks more ordered/organized.
3. Prevents further clean up patches
On Mon, Feb 10, 2014 at 3:20 PM, Sachin Kamat sachin.ka...@linaro.org wrote:
On 10 February 2014 17:51, Lee Jones lee.jo...@linaro.org wrote:
+#include linux/device.h
+#include linux/mfd/core.h
+#include linux/module.h
+#include linux/i2c.h
Please arrange these alphabetically.
Why?
>> + help
>> + Say yes here to support for Maxim Semiconductor MAX6650/MAX6651.
>> This is
>> + a fan speed regulator and monitor IC. This driver provies common
>> support
>
> s/provies/provides/
Good catch!
(Note to myself: I should have run my vim spellchecker... )
>> +
Hi,
On Sat, 2014-02-08 at 11:33 +, Laszlo Papp wrote:
> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
> chip includes fan-speed regulators and monitors, GPIO, and alarm.
>
> This patch is an initial release of a MAX6650/6651 MFD driver that
> supports to enable the
> + * Author: Milo Kim
s/Milo Kim/Laszlo Papp/
I just copied and pasted some existing copyrights, and I, apparently,
have not changed it properly to my name; apologies for that. I will
fix this in the next batch after getting some review from others.
--
To unsubscribe from this list: send the
+ help
+ Say yes here to support for Maxim Semiconductor MAX6650/MAX6651.
This is
+ a fan speed regulator and monitor IC. This driver provies common
support
s/provies/provides/
Good catch!
(Note to myself: I should have run my vim spellchecker... )
+ max665x-map =
+ * Author: Milo Kim laszlo.p...@polatis.com
s/Milo Kim/Laszlo Papp/
I just copied and pasted some existing copyrights, and I, apparently,
have not changed it properly to my name; apologies for that. I will
fix this in the next batch after getting some review from others.
--
To unsubscribe from
Hi,
On Sat, 2014-02-08 at 11:33 +, Laszlo Papp wrote:
MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
chip includes fan-speed regulators and monitors, GPIO, and alarm.
This patch is an initial release of a MAX6650/6651 MFD driver that
supports to enable the chip
MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
chip includes fan-speed regulators and monitors, GPIO, and alarm.
This patch is an initial release of a MAX6650/6651 MFD driver that
supports to enable the chip with its primary I2C bus that will connect
the hwmon, and then the
MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
chip includes fan-speed regulators and monitors, GPIO, and alarm.
This patch is an initial release of a MAX6650/6651 MFD driver that
supports to enable the chip with its primary I2C bus that will connect
the hwmon, and then the
32 matches
Mail list logo
