Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On Sun, Aug 6, 2017 at 12:26 PM, Srinivas Kandagatla wrote: > > > On 04/08/17 23:10, Arnd Bergmann wrote: >> >> How about linking the DML code into the mmci module and making that >> Kconfig option a 'bool'? > > > > Yes, I think making this bool and exporting the

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On Sun, Aug 6, 2017 at 12:26 PM, Srinivas Kandagatla wrote: > > > On 04/08/17 23:10, Arnd Bergmann wrote: >> >> How about linking the DML code into the mmci module and making that >> Kconfig option a 'bool'? > > > > Yes, I think making this bool and exporting the two symbols should fix this. > It

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

Hi Masahiro, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc3 next-20170804] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

Hi Masahiro, [auto build test ERROR on linus/master] [also build test ERROR on v4.13-rc3 next-20170804] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On 04/08/17 23:10, Arnd Bergmann wrote: How about linking the DML code into the mmci module and making that Kconfig option a 'bool'? Yes, I think making this bool and exporting the two symbols should fix this. It does not make sense to make dml helpers a module anyway. If it sounds okay,

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On 04/08/17 23:10, Arnd Bergmann wrote: How about linking the DML code into the mmci module and making that Kconfig option a 'bool'? Yes, I think making this bool and exporting the two symbols should fix this. It does not make sense to make dml helpers a module anyway. If it sounds okay,

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On 6 August 2017 at 11:32, Arnd Bergmann wrote: > On Sun, Aug 6, 2017 at 4:58 AM, Masahiro Yamada > wrote: >> 2017-08-05 7:10 GMT+09:00 Arnd Bergmann : >>> On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada >>>

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On 6 August 2017 at 11:32, Arnd Bergmann wrote: > On Sun, Aug 6, 2017 at 4:58 AM, Masahiro Yamada > wrote: >> 2017-08-05 7:10 GMT+09:00 Arnd Bergmann : >>> On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada >>> wrote: Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On Sun, Aug 6, 2017 at 4:58 AM, Masahiro Yamada wrote: > 2017-08-05 7:10 GMT+09:00 Arnd Bergmann : >> On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada >> wrote: >>> Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On Sun, Aug 6, 2017 at 4:58 AM, Masahiro Yamada wrote: > 2017-08-05 7:10 GMT+09:00 Arnd Bergmann : >> On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada >> wrote: >>> Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following >>> sparse warnings: >>> >>> CHECK

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

Hi Arnd, 2017-08-05 7:10 GMT+09:00 Arnd Bergmann : > On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada > wrote: >> Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following >> sparse warnings: >> >> CHECK drivers/mmc/host/mmci_qcom_dml.c

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

Hi Arnd, 2017-08-05 7:10 GMT+09:00 Arnd Bergmann : > On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada > wrote: >> Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following >> sparse warnings: >> >> CHECK drivers/mmc/host/mmci_qcom_dml.c >> drivers/mmc/host/mmci_qcom_dml.c:57:6:

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada wrote: > Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following > sparse warnings: > > CHECK drivers/mmc/host/mmci_qcom_dml.c > drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was

Re: [PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

On Fri, Aug 4, 2017 at 3:34 PM, Masahiro Yamada wrote: > Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following > sparse warnings: > > CHECK drivers/mmc/host/mmci_qcom_dml.c > drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was > not declared. Should it be

[PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following sparse warnings: CHECK drivers/mmc/host/mmci_qcom_dml.c drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static? drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol

[PATCH v2] mmc: mmci_qcom_dml: include mmci_qcom_dml.h and fix #ifdef

Include mmci_qcom_dml.h from mmci_qcom_dml.c to fix the following sparse warnings: CHECK drivers/mmc/host/mmci_qcom_dml.c drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static? drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol