Re: [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

2015-12-13 22:07 GMT+01:00 Maxime Ripard : [...] >> There is one review comment that I didn't address: Rob Herring suggested >> that this should be in the core-binding rather than in sun4i. I checked >> many of the hardware manuals of other SPI drivers and it looks to me like >> this hardware

Re: [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

Hi, On Fri, Dec 11, 2015 at 11:45:39PM +0100, Marcus Weseloh wrote: > Adds support and binding documentation for a new slave device property > "sun4i,spi-word-wait-ns" that allows to set a hardware based delay > between the transmission of words using the SPI Wait Clock Register. > The SPI

Re: [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

Hi, On Fri, Dec 11, 2015 at 11:45:39PM +0100, Marcus Weseloh wrote: > Adds support and binding documentation for a new slave device property > "sun4i,spi-word-wait-ns" that allows to set a hardware based delay > between the transmission of words using the SPI Wait Clock Register. > The SPI

Re: [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

2015-12-13 22:07 GMT+01:00 Maxime Ripard : [...] >> There is one review comment that I didn't address: Rob Herring suggested >> that this should be in the core-binding rather than in sun4i. I checked >> many of the hardware manuals of other SPI drivers and it

Re: [linux-sunxi] [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

2015-12-12 10:19 GMT+01:00 Priit Laes : > On Fri, 2015-12-11 at 23:45 +0100, Marcus Weseloh wrote: > [...] >> +- sun4i,spi-word-wait-ns: hardware based delay in nanoseconds between >> + transmission of words > > Should be 'allwinner,spi-word-wait-ns' Thanks for the review, I

Re: [linux-sunxi] [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

On Fri, 2015-12-11 at 23:45 +0100, Marcus Weseloh wrote: [...] > > diff --git a/Documentation/devicetree/bindings/spi/spi-sun4i.txt > b/Documentation/devicetree/bindings/spi/spi-sun4i.txt > index de827f5..d6c55fc 100644 > --- a/Documentation/devicetree/bindings/spi/spi-sun4i.txt > +++

Re: [linux-sunxi] [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

On Fri, 2015-12-11 at 23:45 +0100, Marcus Weseloh wrote: [...] > > diff --git a/Documentation/devicetree/bindings/spi/spi-sun4i.txt > b/Documentation/devicetree/bindings/spi/spi-sun4i.txt > index de827f5..d6c55fc 100644 > --- a/Documentation/devicetree/bindings/spi/spi-sun4i.txt > +++

Re: [linux-sunxi] [PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

2015-12-12 10:19 GMT+01:00 Priit Laes : > On Fri, 2015-12-11 at 23:45 +0100, Marcus Weseloh wrote: > [...] >> +- sun4i,spi-word-wait-ns: hardware based delay in nanoseconds between >> + transmission of words > > Should be 'allwinner,spi-word-wait-ns' Thanks

[PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

Adds support and binding documentation for a new slave device property "sun4i,spi-word-wait-ns" that allows to set a hardware based delay between the transmission of words using the SPI Wait Clock Register. The SPI hardware needs 3 clock cycles to set up the delay, which makes the minimum non-zero

[PATCH v2] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

Adds support and binding documentation for a new slave device property "sun4i,spi-word-wait-ns" that allows to set a hardware based delay between the transmission of words using the SPI Wait Clock Register. The SPI hardware needs 3 clock cycles to set up the delay, which makes the minimum non-zero