Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Fri, Sep 25, 2015 at 10:47 AM, Minchan Kim wrote: > On Fri, Sep 25, 2015 at 10:17:54AM +0200, Vitaly Wool wrote: >> >> > I already said questions, opinion and concerns but anything is not clear >> > until now. Only clear thing I could hear is just "compaction stats are >> > better" which is

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On (09/25/15 10:27), Vitaly Wool wrote: > > Have you seen those symptoms before? How did you come up to a conclusion > > that zram->zbud will do the trick? > > I have data from various tests (partially described here: > https://lkml.org/lkml/2015/9/17/244) and once again, I'll post a reply yeah,

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Fri, Sep 25, 2015 at 05:47:13PM +0900, Minchan Kim wrote: > On Fri, Sep 25, 2015 at 10:17:54AM +0200, Vitaly Wool wrote: > > > > > I already said questions, opinion and concerns but anything is not clear > > > until now. Only clear thing I could hear is just "compaction stats are > > > better"

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Fri, Sep 25, 2015 at 10:17:54AM +0200, Vitaly Wool wrote: > > > I already said questions, opinion and concerns but anything is not clear > > until now. Only clear thing I could hear is just "compaction stats are > > better" which is not enough for me. Sorry. > > > > 1)

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

> Have you seen those symptoms before? How did you come up to a conclusion > that zram->zbud will do the trick? I have data from various tests (partially described here: https://lkml.org/lkml/2015/9/17/244) and once again, I'll post a reply to https://lkml.org/lkml/2015/9/15/33 with more detailed

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

> I already said questions, opinion and concerns but anything is not clear > until now. Only clear thing I could hear is just "compaction stats are > better" which is not enough for me. Sorry. > > 1) https://lkml.org/lkml/2015/9/15/33 > 2) https://lkml.org/lkml/2015/9/21/2 Could you please stop

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On (09/25/15 11:13), Minchan Kim wrote: > > Ok, I can see that having the allocator backends for zpool > > have the same set of constraints is nice. > > Sorry for delay. I'm on vacation until next week. > It seems Seth was missed in previous discusstion which was not the end. > > I already said

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On (09/25/15 11:13), Minchan Kim wrote: > > Ok, I can see that having the allocator backends for zpool > > have the same set of constraints is nice. > > Sorry for delay. I'm on vacation until next week. > It seems Seth was missed in previous discusstion which was not the end. > > I already said

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Fri, Sep 25, 2015 at 10:17:54AM +0200, Vitaly Wool wrote: > > > I already said questions, opinion and concerns but anything is not clear > > until now. Only clear thing I could hear is just "compaction stats are > > better" which is not enough for me. Sorry. > > > > 1)

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

> I already said questions, opinion and concerns but anything is not clear > until now. Only clear thing I could hear is just "compaction stats are > better" which is not enough for me. Sorry. > > 1) https://lkml.org/lkml/2015/9/15/33 > 2) https://lkml.org/lkml/2015/9/21/2 Could you please stop

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

> Have you seen those symptoms before? How did you come up to a conclusion > that zram->zbud will do the trick? I have data from various tests (partially described here: https://lkml.org/lkml/2015/9/17/244) and once again, I'll post a reply to https://lkml.org/lkml/2015/9/15/33 with more detailed

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Fri, Sep 25, 2015 at 05:47:13PM +0900, Minchan Kim wrote: > On Fri, Sep 25, 2015 at 10:17:54AM +0200, Vitaly Wool wrote: > > > > > I already said questions, opinion and concerns but anything is not clear > > > until now. Only clear thing I could hear is just "compaction stats are > > > better"

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Fri, Sep 25, 2015 at 10:47 AM, Minchan Kim wrote: > On Fri, Sep 25, 2015 at 10:17:54AM +0200, Vitaly Wool wrote: >> >> > I already said questions, opinion and concerns but anything is not clear >> > until now. Only clear thing I could hear is just "compaction stats are >>

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On (09/25/15 10:27), Vitaly Wool wrote: > > Have you seen those symptoms before? How did you come up to a conclusion > > that zram->zbud will do the trick? > > I have data from various tests (partially described here: > https://lkml.org/lkml/2015/9/17/244) and once again, I'll post a reply yeah,

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

Hello Seth, On Thu, Sep 24, 2015 at 12:41 AM, Seth Jennings wrote: > On Wed, Sep 23, 2015 at 10:59:00PM +0200, Vitaly Wool wrote: >> Okay, how about this? It's gotten smaller BTW :) >> >> zbud: allow up to PAGE_SIZE allocations >> >> Currently zbud is only capable of allocating not more than >>

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

Hello, On Wed, Sep 23, 2015 at 04:57:26PM -0500, Seth Jennings wrote: > On Wed, Sep 23, 2015 at 09:54:02AM +0200, Vitaly Wool wrote: > > On Wed, Sep 23, 2015 at 5:18 AM, Seth Jennings > > wrote: > > > On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: > > >> Currently zbud is only

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

Hello, On Wed, Sep 23, 2015 at 04:57:26PM -0500, Seth Jennings wrote: > On Wed, Sep 23, 2015 at 09:54:02AM +0200, Vitaly Wool wrote: > > On Wed, Sep 23, 2015 at 5:18 AM, Seth Jennings > > wrote: > > > On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: > > >>

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

Hello Seth, On Thu, Sep 24, 2015 at 12:41 AM, Seth Jennings wrote: > On Wed, Sep 23, 2015 at 10:59:00PM +0200, Vitaly Wool wrote: >> Okay, how about this? It's gotten smaller BTW :) >> >> zbud: allow up to PAGE_SIZE allocations >> >> Currently zbud is only capable of

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Wed, Sep 23, 2015 at 10:59:00PM +0200, Vitaly Wool wrote: > Okay, how about this? It's gotten smaller BTW :) > > zbud: allow up to PAGE_SIZE allocations > > Currently zbud is only capable of allocating not more than > PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as > long as only

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Wed, Sep 23, 2015 at 09:54:02AM +0200, Vitaly Wool wrote: > On Wed, Sep 23, 2015 at 5:18 AM, Seth Jennings > wrote: > > On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: > >> Currently zbud is only capable of allocating not more than > >> PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE.

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

Okay, how about this? It's gotten smaller BTW :) zbud: allow up to PAGE_SIZE allocations Currently zbud is only capable of allocating not more than PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as long as only zswap is using it, but other users of zbud may (and likely will) want to

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Tue, Sep 22, 2015 at 11:49 PM, Dan Streetman wrote: > On Tue, Sep 22, 2015 at 8:17 AM, Vitaly Wool wrote: >> Currently zbud is only capable of allocating not more than >> PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as >> long as only zswap is using it, but other users of zbud may

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Wed, Sep 23, 2015 at 5:18 AM, Seth Jennings wrote: > On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: >> Currently zbud is only capable of allocating not more than >> PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as >> long as only zswap is using it, but other users of

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Tue, Sep 22, 2015 at 11:49 PM, Dan Streetman wrote: > On Tue, Sep 22, 2015 at 8:17 AM, Vitaly Wool wrote: >> Currently zbud is only capable of allocating not more than >> PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as >> long as only zswap

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Wed, Sep 23, 2015 at 5:18 AM, Seth Jennings wrote: > On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: >> Currently zbud is only capable of allocating not more than >> PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as >> long as only zswap is

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Wed, Sep 23, 2015 at 09:54:02AM +0200, Vitaly Wool wrote: > On Wed, Sep 23, 2015 at 5:18 AM, Seth Jennings > wrote: > > On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: > >> Currently zbud is only capable of allocating not more than > >> PAGE_SIZE -

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

Okay, how about this? It's gotten smaller BTW :) zbud: allow up to PAGE_SIZE allocations Currently zbud is only capable of allocating not more than PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as long as only zswap is using it, but other users of zbud may (and likely will) want to

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Wed, Sep 23, 2015 at 10:59:00PM +0200, Vitaly Wool wrote: > Okay, how about this? It's gotten smaller BTW :) > > zbud: allow up to PAGE_SIZE allocations > > Currently zbud is only capable of allocating not more than > PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as > long as only

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: > Currently zbud is only capable of allocating not more than > PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as > long as only zswap is using it, but other users of zbud may > (and likely will) want to allocate up to

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Tue, Sep 22, 2015 at 8:17 AM, Vitaly Wool wrote: > Currently zbud is only capable of allocating not more than > PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as > long as only zswap is using it, but other users of zbud may > (and likely will) want to allocate up to PAGE_SIZE. This

[PATCH v2] zbud: allow up to PAGE_SIZE allocations

Currently zbud is only capable of allocating not more than PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as long as only zswap is using it, but other users of zbud may (and likely will) want to allocate up to PAGE_SIZE. This patch addresses that by skipping the creation of zbud internal

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Tue, Sep 22, 2015 at 8:17 AM, Vitaly Wool wrote: > Currently zbud is only capable of allocating not more than > PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as > long as only zswap is using it, but other users of zbud may > (and likely will) want to allocate

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: > Currently zbud is only capable of allocating not more than > PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as > long as only zswap is using it, but other users of zbud may > (and likely will) want to allocate up to

[PATCH v2] zbud: allow up to PAGE_SIZE allocations

Currently zbud is only capable of allocating not more than PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as long as only zswap is using it, but other users of zbud may (and likely will) want to allocate up to PAGE_SIZE. This patch addresses that by skipping the creation of zbud internal