Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-09 Thread Maxime Ripard
On Wed, Jun 07, 2017 at 10:21:02PM +0800, Icenowy Zheng wrote: > > > 于 2017年6月7日 GMT+08:00 下午10:19:57, Maxime Ripard > 写到: > >On Wed, Jun 07, 2017 at 05:44:56PM +0800, Icenowy Zheng wrote: > >> 于 2017年6月7日 GMT+08:00 下午5:43:43, Maxime Ripard > > 写到: > >> >On Mon, Jun 05, 2017 at 03:03:47AM +0800

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-07 Thread Maxime Ripard
On Wed, Jun 07, 2017 at 05:44:56PM +0800, Icenowy Zheng wrote: > 于 2017年6月7日 GMT+08:00 下午5:43:43, Maxime Ripard > 写到: > >On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote: > >> >You should also expand function sun4i_drv_node_is_tcon() at > >sun4i_drv.c > >> >with > >> >new entries, b

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-07 Thread Icenowy Zheng
于 2017年6月7日 GMT+08:00 下午10:19:57, Maxime Ripard 写到: >On Wed, Jun 07, 2017 at 05:44:56PM +0800, Icenowy Zheng wrote: >> 于 2017年6月7日 GMT+08:00 下午5:43:43, Maxime Ripard > 写到: >> >On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote: >> >> >You should also expand function sun4i_drv_node_is

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-07 Thread Icenowy Zheng
于 2017年6月7日 GMT+08:00 下午5:43:43, Maxime Ripard 写到: >On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote: >> >You should also expand function sun4i_drv_node_is_tcon() at >sun4i_drv.c >> >with >> >new entries, but I'm not sure if this fits in this patch. >> >> Instead I think it shoul

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-07 Thread Icenowy Zheng
于 2017年6月7日 GMT+08:00 下午5:43:43, Maxime Ripard 写到: >On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote: >> >You should also expand function sun4i_drv_node_is_tcon() at >sun4i_drv.c >> >with >> >new entries, but I'm not sure if this fits in this patch. >> >> Instead I think it shoul

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-07 Thread Maxime Ripard
On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote: > >You should also expand function sun4i_drv_node_is_tcon() at sun4i_drv.c > >with > >new entries, but I'm not sure if this fits in this patch. > > Instead I think it should be renamed to something like > "sun4i_drv_node_is_tcon_with_

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-04 Thread kbuild test robot
Hi Icenowy, [auto build test ERROR on next-20170602] [cannot apply to mripard/sunxi/for-next robh/for-next clk/clk-next v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.12-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/li

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-04 Thread Icenowy Zheng
于 2017年6月5日 GMT+08:00 上午2:46:24, "Jernej Škrabec" 写到: >Hi, > >Dne nedelja, 04. junij 2017 ob 18:01:42 CEST je Icenowy Zheng >napisal(a): >> From: Icenowy Zheng >> >> Allwinner H3 has two special TCONs, both come without channel0. And >the >> TCON1 of H3 has no special clocks even for the chann

Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-04 Thread Jernej Škrabec
Hi, Dne nedelja, 04. junij 2017 ob 18:01:42 CEST je Icenowy Zheng napisal(a): > From: Icenowy Zheng > > Allwinner H3 has two special TCONs, both come without channel0. And the > TCON1 of H3 has no special clocks even for the channel1. > > Add support for these kinds of TCON. > > Signed-off-by:

[PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

2017-06-04 Thread Icenowy Zheng
From: Icenowy Zheng Allwinner H3 has two special TCONs, both come without channel0. And the TCON1 of H3 has no special clocks even for the channel1. Add support for these kinds of TCON. Signed-off-by: Icenowy Zheng --- Changes in v2: - Merged TCON0 and TCON1 quirks and compatibles. drivers/g