Re: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support

Hi Stephen, On Mon, Jun 20, 2016 at 06:15:37PM -0700, Stephen Boyd wrote: > On 06/07, Maxime Ripard wrote: > > + > > +#include > > + > > +#include "ccu_common.h" > > + > > +struct ccu_fixed_factor { > > + u16 div; > > + u16 mult; > > + > > + struct

Re: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support

Hi Stephen, On Mon, Jun 20, 2016 at 06:15:37PM -0700, Stephen Boyd wrote: > On 06/07, Maxime Ripard wrote: > > + > > +#include > > + > > +#include "ccu_common.h" > > + > > +struct ccu_fixed_factor { > > + u16 div; > > + u16 mult; > > + > > + struct

Re: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support

On 06/07, Maxime Ripard wrote: > + > +#include > + > +#include "ccu_common.h" > + > +struct ccu_fixed_factor { > + u16 div; > + u16 mult; > + > + struct ccu_common common; Does this use the common structure although we have no usage for

Re: [PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support

On 06/07, Maxime Ripard wrote: > + > +#include > + > +#include "ccu_common.h" > + > +struct ccu_fixed_factor { > + u16 div; > + u16 mult; > + > + struct ccu_common common; Does this use the common structure although we have no usage for

[PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support

Some clocks in the Allwinner SoCs clock units are direct, fixed, multipliers or dividers from their parent. Add support for such clocks. Signed-off-by: Maxime Ripard --- drivers/clk/sunxi-ng/Makefile | 2 ++ drivers/clk/sunxi-ng/ccu_fixed_factor.c |

[PATCH v2 04/15] clk: sunxi-ng: Add fixed factor clock support

Some clocks in the Allwinner SoCs clock units are direct, fixed, multipliers or dividers from their parent. Add support for such clocks. Signed-off-by: Maxime Ripard --- drivers/clk/sunxi-ng/Makefile | 2 ++ drivers/clk/sunxi-ng/ccu_fixed_factor.c | 50