Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Philipp, Thanks for reviewing. On 03/16/2018 02:29 PM, Philipp Zabel wrote: > Hi Gabriel, > > this looks mostly good to me, a few questions and comments below: > > On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >>

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Philipp, Thanks for reviewing. On 03/16/2018 02:29 PM, Philipp Zabel wrote: > Hi Gabriel, > > this looks mostly good to me, a few questions and comments below: > > On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> stm32mp1 RCC IP 1 has a

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Gabriel, this looks mostly good to me, a few questions and comments below: On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > stm32mp1 RCC IP 1 has a reset SET register and a reset CLEAR register. > > Writing '0' on

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Gabriel, this looks mostly good to me, a few questions and comments below: On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > stm32mp1 RCC IP 1 has a reset SET register and a reset CLEAR register. > > Writing '0' on reset SET register has no

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Gabriel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [also build test WARNING on v4.16-rc5] [cannot apply to linus/master v4.16-rc4 v4.16-rc3 v4.16-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Gabriel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [also build test WARNING on v4.16-rc5] [cannot apply to linus/master v4.16-rc4 v4.16-rc3 v4.16-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help

[PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

From: Gabriel Fernandez stm32mp1 RCC IP 1 has a reset SET register and a reset CLEAR register. Writing '0' on reset SET register has no effect Writing '1' on reset SET register activates the reset of the corresponding peripheral Writing '0' on reset CLEAR

[PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

From: Gabriel Fernandez stm32mp1 RCC IP 1 has a reset SET register and a reset CLEAR register. Writing '0' on reset SET register has no effect Writing '1' on reset SET register activates the reset of the corresponding peripheral Writing '0' on reset CLEAR register has no effect