Re: [PATCH v2 22/25] tty: serial: samsung_tty: Add support for Apple UARTs

2021-02-18 Thread Hector Martin
On 16/02/2021 04.13, Krzysztof Kozlowski wrote: On Mon, Feb 15, 2021 at 09:17:10PM +0900, Hector Martin wrote: @@ -389,10 +396,12 @@ static void enable_tx_pio(struct s3c24xx_uart_port *ourport) ucon = rd_regl(port, S3C2410_UCON); ucon &= ~(S3C64XX_UCON_TXMODE_MASK);

Re: [PATCH v2 22/25] tty: serial: samsung_tty: Add support for Apple UARTs

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:10PM +0900, Hector Martin wrote: > Apple SoCs are a distant descendant of Samsung designs and use yet > another variant of their UART style, with different interrupt handling. > > In particular, this variant has the following differences with existing > ones: > > *

[PATCH v2 22/25] tty: serial: samsung_tty: Add support for Apple UARTs

2021-02-15 Thread Hector Martin
Apple SoCs are a distant descendant of Samsung designs and use yet another variant of their UART style, with different interrupt handling. In particular, this variant has the following differences with existing ones: * It includes a built-in interrupt controller with different registers, using