Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration

2019-08-20 Thread Dan Murphy
Hello On 8/20/19 11:29 AM, Pavel Machek wrote: Hi! No need to move ctrl_brt_pointer... to keep order consistent with docs. OK I will reset the patches and get rid of that change.  I think this got moved when I applied the v1 patch. + fs_current_val = led->full_scale_current

Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration

2019-08-20 Thread Pavel Machek
Hi! > >No need to move ctrl_brt_pointer... to keep order consistent with docs. > > OK I will reset the patches and get rid of that change.  I think this got > moved when I applied the v1 patch. > > > >>+ fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN / > >>+

Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration

2019-08-20 Thread Dan Murphy
Pavel Thanks for the review On 8/19/19 5:55 AM, Pavel Machek wrote: Hi! Allow the full scale current to be configured at init. Valid rangles are 5mA->29.8mA. Signed-off-by: Dan Murphy @@ -121,6 +125,7 @@ struct lm3532_als_data { * @mode - Mode of the LED string * @ctrl_brt_pointer -

Re: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration

2019-08-19 Thread Pavel Machek
Hi! > Allow the full scale current to be configured at init. > Valid rangles are 5mA->29.8mA. > > Signed-off-by: Dan Murphy > @@ -121,6 +125,7 @@ struct lm3532_als_data { > * @mode - Mode of the LED string > * @ctrl_brt_pointer - Zone target register that controls the sink > * @num_leds

[PATCH v2 4/4] leds: lm3532: Add full scale current configuration

2019-08-13 Thread Dan Murphy
Allow the full scale current to be configured at init. Valid rangles are 5mA->29.8mA. Signed-off-by: Dan Murphy --- v2 - Change ti,fs-current to led-max-microamp - https://lore.kernel.org/patchwork/patch/1109503/ drivers/leds/leds-lm3532.c | 26 +- 1 file changed, 25