Re: [PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes

2016-11-21 Thread maitysanchayan
On 16-11-21 15:22:09, Stefan Agner wrote: > On 2016-11-20 21:54, Sanchayan Maity wrote: > > Code cleanup for improving code readability and error path fixes > > and cleanup removing use of devm_kfree. > > Two things in one, not very nice. Especially the dma_free_coherent is > really a bug and the

Re: [PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes

2016-11-21 Thread maitysanchayan
On 16-11-21 15:22:09, Stefan Agner wrote: > On 2016-11-20 21:54, Sanchayan Maity wrote: > > Code cleanup for improving code readability and error path fixes > > and cleanup removing use of devm_kfree. > > Two things in one, not very nice. Especially the dma_free_coherent is > really a bug and the

Re: [PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes

2016-11-21 Thread Stefan Agner
On 2016-11-20 21:54, Sanchayan Maity wrote: > Code cleanup for improving code readability and error path fixes > and cleanup removing use of devm_kfree. Two things in one, not very nice. Especially the dma_free_coherent is really a bug and the other is a cleanup. Can you make a separate patch for

Re: [PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes

2016-11-21 Thread Stefan Agner
On 2016-11-20 21:54, Sanchayan Maity wrote: > Code cleanup for improving code readability and error path fixes > and cleanup removing use of devm_kfree. Two things in one, not very nice. Especially the dma_free_coherent is really a bug and the other is a cleanup. Can you make a separate patch for

[PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes

2016-11-20 Thread Sanchayan Maity
Code cleanup for improving code readability and error path fixes and cleanup removing use of devm_kfree. Signed-off-by: Sanchayan Maity --- drivers/spi/spi-fsl-dspi.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git

[PATCH v2 4/4] spi: spi-fsl-dspi: Minor code cleanup and error path fixes

2016-11-20 Thread Sanchayan Maity
Code cleanup for improving code readability and error path fixes and cleanup removing use of devm_kfree. Signed-off-by: Sanchayan Maity --- drivers/spi/spi-fsl-dspi.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-dspi.c