Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Wei Wang
On 04/11/2018 07:25 AM, Michael S. Tsirkin wrote: On Tue, Apr 10, 2018 at 01:54:29PM -0700, Andrew Morton wrote: On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" wrote: Andrew, were your questions answered? If yes could I bother you for an ack on this? Still not

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Wei Wang
On 04/11/2018 07:25 AM, Michael S. Tsirkin wrote: On Tue, Apr 10, 2018 at 01:54:29PM -0700, Andrew Morton wrote: On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" wrote: Andrew, were your questions answered? If yes could I bother you for an ack on this? Still not very happy that

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Michael S. Tsirkin
On Tue, Apr 10, 2018 at 01:54:29PM -0700, Andrew Morton wrote: > On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" > wrote: > > > > > Andrew, were your questions answered? If yes could I bother you for an ack > > on this? > > > > Still not very happy that readers are

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Michael S. Tsirkin
On Tue, Apr 10, 2018 at 01:54:29PM -0700, Andrew Morton wrote: > On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" > wrote: > > > > > Andrew, were your questions answered? If yes could I bother you for an ack > > on this? > > > > Still not very happy that readers are told that "this

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Andrew Morton
On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" wrote: > > Andrew, were your questions answered? If yes could I bother you for an ack on > this? > Still not very happy that readers are told that "this function may sleep" when it clearly doesn't do so. If we wish to

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Andrew Morton
On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" wrote: > > Andrew, were your questions answered? If yes could I bother you for an ack on > this? > Still not very happy that readers are told that "this function may sleep" when it clearly doesn't do so. If we wish to be able to change

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Michael S. Tsirkin
On Mon, Mar 26, 2018 at 02:22:54PM -0700, Andrew Morton wrote: > On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > > > This patch adds support to walk through the free page blocks in the > > system and report them via a callback function. Some page blocks may > > leave

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-04-10 Thread Michael S. Tsirkin
On Mon, Mar 26, 2018 at 02:22:54PM -0700, Andrew Morton wrote: > On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > > > This patch adds support to walk through the free page blocks in the > > system and report them via a callback function. Some page blocks may > > leave the free list after

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-28 Thread Michal Hocko
On Tue 27-03-18 19:07:22, Michael S. Tsirkin wrote: > On Tue, Mar 27, 2018 at 08:33:22AM +0200, Michal Hocko wrote: > > > > > + * The function itself might sleep so it cannot be called from atomic > > > > > + * contexts. > > > > I don't see how walk_free_mem_block() can sleep. > > > > > > OK, it

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-28 Thread Michal Hocko
On Tue 27-03-18 19:07:22, Michael S. Tsirkin wrote: > On Tue, Mar 27, 2018 at 08:33:22AM +0200, Michal Hocko wrote: > > > > > + * The function itself might sleep so it cannot be called from atomic > > > > > + * contexts. > > > > I don't see how walk_free_mem_block() can sleep. > > > > > > OK, it

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-27 Thread Michael S. Tsirkin
On Tue, Mar 27, 2018 at 08:33:22AM +0200, Michal Hocko wrote: > > > > + * The function itself might sleep so it cannot be called from atomic > > > > + * contexts. > > > I don't see how walk_free_mem_block() can sleep. > > > > OK, it would be better to remove this sentence for the current version.

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-27 Thread Michael S. Tsirkin
On Tue, Mar 27, 2018 at 08:33:22AM +0200, Michal Hocko wrote: > > > > + * The function itself might sleep so it cannot be called from atomic > > > > + * contexts. > > > I don't see how walk_free_mem_block() can sleep. > > > > OK, it would be better to remove this sentence for the current version.

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-27 Thread Michal Hocko
On Tue 27-03-18 14:23:51, Wei Wang wrote: > On 03/27/2018 05:22 AM, Andrew Morton wrote: > > On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > > > > > This patch adds support to walk through the free page blocks in the > > > system and report them via a callback

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-27 Thread Michal Hocko
On Tue 27-03-18 14:23:51, Wei Wang wrote: > On 03/27/2018 05:22 AM, Andrew Morton wrote: > > On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > > > > > This patch adds support to walk through the free page blocks in the > > > system and report them via a callback function. Some page blocks may

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-27 Thread Wei Wang
On 03/27/2018 05:22 AM, Andrew Morton wrote: On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-27 Thread Wei Wang
On 03/27/2018 05:22 AM, Andrew Morton wrote: On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's >

Re: [PATCH v29 1/4] mm: support reporting free page blocks

2018-03-26 Thread Andrew Morton
On Mon, 26 Mar 2018 10:39:51 +0800 Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either

[PATCH v29 1/4] mm: support reporting free page blocks

2018-03-25 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of

[PATCH v29 1/4] mm: support reporting free page blocks

2018-03-25 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of