Re: [PATCH v3 05/11] drm/sun4i: abstract a mixer type

2017-04-03 Thread Maxime Ripard
Hi, That's much better thanks, but I have a bunch of (minor) comments. On Thu, Mar 30, 2017 at 03:46:07AM +0800, Icenowy Zheng wrote: > diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c > b/drivers/gpu/drm/sun4i/sun4i_crtc.c > index 33854ee7f636..938dfe7188ff 100644 > ---

Re: [PATCH v3 05/11] drm/sun4i: abstract a mixer type

2017-04-03 Thread Maxime Ripard
Hi, That's much better thanks, but I have a bunch of (minor) comments. On Thu, Mar 30, 2017 at 03:46:07AM +0800, Icenowy Zheng wrote: > diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c > b/drivers/gpu/drm/sun4i/sun4i_crtc.c > index 33854ee7f636..938dfe7188ff 100644 > ---

[PATCH v3 05/11] drm/sun4i: abstract a mixer type

2017-03-29 Thread Icenowy Zheng
As we are going to add support for the Allwinner DE2 mixer in sun4i-drm driver, we will finally have two types of display mixers -- the DE1 backend and the DE2 mixer. They both do some display blending and feed graphics data to TCON, so I choose to call them both "mixer" here. Abstract the mixer

[PATCH v3 05/11] drm/sun4i: abstract a mixer type

2017-03-29 Thread Icenowy Zheng
As we are going to add support for the Allwinner DE2 mixer in sun4i-drm driver, we will finally have two types of display mixers -- the DE1 backend and the DE2 mixer. They both do some display blending and feed graphics data to TCON, so I choose to call them both "mixer" here. Abstract the mixer