Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-29 Thread Rafael J. Wysocki
On Wed, Jul 29, 2020 at 3:35 AM Vishal Verma wrote: > > On Mon, 2020-07-27 at 14:37 +0200, Rafael J. Wysocki wrote: > > On Tue, Jul 21, 2020 at 12:24 AM Dan Williams > > wrote: > > > Abstract platform specific mechanics for nvdimm firmware activation > > > behind a handful of generic ops. At

Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-28 Thread Vishal Verma
On Mon, 2020-07-27 at 14:37 +0200, Rafael J. Wysocki wrote: > On Tue, Jul 21, 2020 at 12:24 AM Dan Williams > wrote: > > Abstract platform specific mechanics for nvdimm firmware activation > > behind a handful of generic ops. At the bus level ->activate_state() > > indicates the unified state

Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-27 Thread Rafael J. Wysocki
On Tue, Jul 21, 2020 at 12:24 AM Dan Williams wrote: > > Abstract platform specific mechanics for nvdimm firmware activation > behind a handful of generic ops. At the bus level ->activate_state() > indicates the unified state (idle, busy, armed) of all DIMMs on the bus, > and ->capability()

Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-21 Thread kernel test robot
Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on 48778464bb7d346b47157d21ffde2af6b2d39110] url: https://github.com/0day-ci/linux/commits/Dan-Williams/ACPI-NVDIMM-Runtime-Firmware-Activation/20200721-062902 base:48778464bb7d346b47157d21ffde2af6b2d39110

Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-20 Thread Dan Williams
On Mon, Jul 20, 2020 at 5:14 PM Vishal Verma wrote: > > On Mon, 2020-07-20 at 17:02 -0700, Randy Dunlap wrote: > > Hi Dan, > > > > Documentation comments below: > > Dan, Randy, > > I'm happy to fix these up when applying. Sounds good. Thanks Vishal.

Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-20 Thread Dan Williams
On Mon, Jul 20, 2020 at 5:02 PM Randy Dunlap wrote: > > Hi Dan, > > Documentation comments below: > > On 7/20/20 3:08 PM, Dan Williams wrote: > > Abstract platform specific mechanics for nvdimm firmware activation > > behind a handful of generic ops. At the bus level ->activate_state() > >

Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-20 Thread Vishal Verma
On Mon, 2020-07-20 at 17:02 -0700, Randy Dunlap wrote: > Hi Dan, > > Documentation comments below: Dan, Randy, I'm happy to fix these up when applying. > > On 7/20/20 3:08 PM, Dan Williams wrote: > > Abstract platform specific mechanics for nvdimm firmware activation > > behind a handful of

Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-20 Thread Randy Dunlap
Hi Dan, Documentation comments below: On 7/20/20 3:08 PM, Dan Williams wrote: > Abstract platform specific mechanics for nvdimm firmware activation > behind a handful of generic ops. At the bus level ->activate_state() > indicates the unified state (idle, busy, armed) of all DIMMs on the bus, >

[PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support

2020-07-20 Thread Dan Williams
Abstract platform specific mechanics for nvdimm firmware activation behind a handful of generic ops. At the bus level ->activate_state() indicates the unified state (idle, busy, armed) of all DIMMs on the bus, and ->capability() indicates the system state expectations for activate. At the DIMM