Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-27 Thread Rui Miguel Silva
Hi Sakari, On Sat 24 Mar 2018 at 10:57, Sakari Ailus wrote: Hi Rui, I wanted to go through the code the last time and I'd have a few review comments below... Thanks for the review. On Tue, Mar 13, 2018 at 11:33:11AM +, Rui Miguel Silva wrote: ... +static int ov2680_gain_set(struct

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-27 Thread Rui Miguel Silva
Hi Sakari, On Sat 24 Mar 2018 at 10:57, Sakari Ailus wrote: Hi Rui, I wanted to go through the code the last time and I'd have a few review comments below... Thanks for the review. On Tue, Mar 13, 2018 at 11:33:11AM +, Rui Miguel Silva wrote: ... +static int ov2680_gain_set(struct

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-24 Thread Sakari Ailus
Hi Rui, I wanted to go through the code the last time and I'd have a few review comments below... On Tue, Mar 13, 2018 at 11:33:11AM +, Rui Miguel Silva wrote: ... > +static int ov2680_gain_set(struct ov2680_dev *sensor, bool auto_gain) > +{ > + struct ov2680_ctrls *ctrls = >ctrls; > +

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-24 Thread Sakari Ailus
Hi Rui, I wanted to go through the code the last time and I'd have a few review comments below... On Tue, Mar 13, 2018 at 11:33:11AM +, Rui Miguel Silva wrote: ... > +static int ov2680_gain_set(struct ov2680_dev *sensor, bool auto_gain) > +{ > + struct ov2680_ctrls *ctrls = >ctrls; > +

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-16 Thread Rui Miguel Silva
Hi Sakari, On Fri 16 Mar 2018 at 16:10, Sakari Ailus wrote: On Thu, Mar 15, 2018 at 09:29:33AM +, Rui Miguel Silva wrote: Hi, On Wed 14 Mar 2018 at 19:39, kbuild test robot wrote: > Hi Rui, > > I love your patch! Yet something to improve: > > [auto build test ERROR on v4.16-rc4] >

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-16 Thread Rui Miguel Silva
Hi Sakari, On Fri 16 Mar 2018 at 16:10, Sakari Ailus wrote: On Thu, Mar 15, 2018 at 09:29:33AM +, Rui Miguel Silva wrote: Hi, On Wed 14 Mar 2018 at 19:39, kbuild test robot wrote: > Hi Rui, > > I love your patch! Yet something to improve: > > [auto build test ERROR on v4.16-rc4] >

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-16 Thread Sakari Ailus
On Thu, Mar 15, 2018 at 09:29:33AM +, Rui Miguel Silva wrote: > Hi, > On Wed 14 Mar 2018 at 19:39, kbuild test robot wrote: > > Hi Rui, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on v4.16-rc4] > > [cannot apply to next-20180314] > > [if your patch is

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-16 Thread Sakari Ailus
On Thu, Mar 15, 2018 at 09:29:33AM +, Rui Miguel Silva wrote: > Hi, > On Wed 14 Mar 2018 at 19:39, kbuild test robot wrote: > > Hi Rui, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on v4.16-rc4] > > [cannot apply to next-20180314] > > [if your patch is

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-15 Thread Rui Miguel Silva
Hi, On Wed 14 Mar 2018 at 19:39, kbuild test robot wrote: Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180314] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-15 Thread Rui Miguel Silva
Hi, On Wed 14 Mar 2018 at 19:39, kbuild test robot wrote: Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180314] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-14 Thread kbuild test robot
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180314] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-14 Thread kbuild test robot
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180314] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-14 Thread kbuild test robot
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180314] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-14 Thread kbuild test robot
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [cannot apply to next-20180314] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Rui Miguel Silva
This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Supports output format: 10-bit Raw RGB. The OV2680 has a single lane MIPI interface. The driver exposes following V4L2 controls: - auto/manual exposure, - exposure, -

[PATCH v3 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-03-13 Thread Rui Miguel Silva
This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Supports output format: 10-bit Raw RGB. The OV2680 has a single lane MIPI interface. The driver exposes following V4L2 controls: - auto/manual exposure, - exposure, -