Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Luck, Tony
On Mon, Oct 17, 2016 at 09:43:41AM -0700, Yu, Fenghua wrote: > > > > I wonder whether this is the proper abstraction level. We might as > > > > well do the following: > > > > > > > > rdtresources[] = { > > > > { > > > > .name = "L3", > > > > }, > > > > { > > > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Luck, Tony
On Mon, Oct 17, 2016 at 09:43:41AM -0700, Yu, Fenghua wrote: > > > > I wonder whether this is the proper abstraction level. We might as > > > > well do the following: > > > > > > > > rdtresources[] = { > > > > { > > > > .name = "L3", > > > > }, > > > > { > > > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Fenghua Yu
On Mon, Oct 17, 2016 at 07:02:19PM +0200, Thomas Gleixner wrote: > On Mon, 17 Oct 2016, Fenghua Yu wrote: > > On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > > > I wonder whether this is the proper abstraction level. We might as well do > > > the following: > > > > > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Fenghua Yu
On Mon, Oct 17, 2016 at 07:02:19PM +0200, Thomas Gleixner wrote: > On Mon, 17 Oct 2016, Fenghua Yu wrote: > > On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > > > I wonder whether this is the proper abstraction level. We might as well do > > > the following: > > > > > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Mon, 17 Oct 2016, Fenghua Yu wrote: > On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > > I wonder whether this is the proper abstraction level. We might as well do > > the following: > > > > rdtresources[] = { > > { > > .name = "L3", > > }, > > { > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Mon, 17 Oct 2016, Fenghua Yu wrote: > On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > > I wonder whether this is the proper abstraction level. We might as well do > > the following: > > > > rdtresources[] = { > > { > > .name = "L3", > > }, > > { > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Mon, 17 Oct 2016, Fenghua Yu wrote: > On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > > On Fri, 14 Oct 2016, Fenghua Yu wrote: > > > +/** > > > + * struct rdt_resource - attributes of an RDT resource > > > + * @enabled: Is this feature enabled on this

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Mon, 17 Oct 2016, Luck, Tony wrote: > > > I wonder whether this is the proper abstraction level. We might as well do > > > the following: > > > > > > rdtresources[] = { > > > { > > > .name = "L3", > > > }, > > > { > > > .name = "L3Data", > > > }, > > > { > > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Mon, 17 Oct 2016, Fenghua Yu wrote: > On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > > On Fri, 14 Oct 2016, Fenghua Yu wrote: > > > +/** > > > + * struct rdt_resource - attributes of an RDT resource > > > + * @enabled: Is this feature enabled on this

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Mon, 17 Oct 2016, Luck, Tony wrote: > > > I wonder whether this is the proper abstraction level. We might as well do > > > the following: > > > > > > rdtresources[] = { > > > { > > > .name = "L3", > > > }, > > > { > > > .name = "L3Data", > > > }, > > > { > > >

RE: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Yu, Fenghua
> > > I wonder whether this is the proper abstraction level. We might as > > > well do the following: > > > > > > rdtresources[] = { > > > { > > > .name = "L3", > > > }, > > > { > > > .name = "L3Data", > > > }, > > > { > > > .name = "L3Code", > > > }, > >

RE: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Yu, Fenghua
> > > I wonder whether this is the proper abstraction level. We might as > > > well do the following: > > > > > > rdtresources[] = { > > > { > > > .name = "L3", > > > }, > > > { > > > .name = "L3Data", > > > }, > > > { > > > .name = "L3Code", > > > }, > >

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Luck, Tony
> > I wonder whether this is the proper abstraction level. We might as well do > > the following: > > > > rdtresources[] = { > > { > > .name = "L3", > > }, > > { > > .name = "L3Data", > > }, > > { > > .name = "L3Code", > > }, > > > > and enable

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Luck, Tony
> > I wonder whether this is the proper abstraction level. We might as well do > > the following: > > > > rdtresources[] = { > > { > > .name = "L3", > > }, > > { > > .name = "L3Data", > > }, > > { > > .name = "L3Code", > > }, > > > > and enable

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Fenghua Yu
On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > On Fri, 14 Oct 2016, Fenghua Yu wrote: > > +/** > > + * struct rdt_resource - attributes of an RDT resource > > + * @enabled: Is this feature enabled on this machine > > + * @name: Name to use

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Fenghua Yu
On Mon, Oct 17, 2016 at 03:45:32PM +0200, Thomas Gleixner wrote: > On Fri, 14 Oct 2016, Fenghua Yu wrote: > > +/** > > + * struct rdt_resource - attributes of an RDT resource > > + * @enabled: Is this feature enabled on this machine > > + * @name: Name to use

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Fri, 14 Oct 2016, Fenghua Yu wrote: > +/** > + * struct rdt_resource - attributes of an RDT resource > + * @enabled: Is this feature enabled on this machine > + * @name:Name to use in "schemata" file > + * @max_closid: Maximum number of

Re: [PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-17 Thread Thomas Gleixner
On Fri, 14 Oct 2016, Fenghua Yu wrote: > +/** > + * struct rdt_resource - attributes of an RDT resource > + * @enabled: Is this feature enabled on this machine > + * @name:Name to use in "schemata" file > + * @max_closid: Maximum number of

[PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-14 Thread Fenghua Yu
From: Fenghua Yu Define struct rdt_resource to hold all the parameterized values for an RDT resource. Fill in some of those values from CPUID leaf 0x10 (on Haswell we hard code them). Signed-off-by: Fenghua Yu Signed-off-by: Tony Luck

[PATCH v4 08/18] x86/intel_rdt: Pick up L3/L2 RDT parameters from CPUID

2016-10-14 Thread Fenghua Yu
From: Fenghua Yu Define struct rdt_resource to hold all the parameterized values for an RDT resource. Fill in some of those values from CPUID leaf 0x10 (on Haswell we hard code them). Signed-off-by: Fenghua Yu Signed-off-by: Tony Luck --- arch/x86/include/asm/intel_rdt.h | 62