Re: [PATCH v4 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-04-09 Thread Peter Ujfalusi
>> +static inline void ti_dma_xbar_write(void __iomem *iomem, int xbar, int val) >> +{ >> +writew_relaxed(val, iomem + (xbar * 2)); > > Silently casting val (an integer) to a u16 isn't really nice I > guess. At least you could be upfront about it in the prototype. The value in val is

Re: [PATCH v4 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-04-09 Thread Peter Ujfalusi
+static inline void ti_dma_xbar_write(void __iomem *iomem, int xbar, int val) +{ +writew_relaxed(val, iomem + (xbar * 2)); Silently casting val (an integer) to a u16 isn't really nice I guess. At least you could be upfront about it in the prototype. The value in val is guarantied not

Re: [PATCH v4 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-04-08 Thread Maxime Ripard
Hi, On Wed, Apr 08, 2015 at 04:14:47PM +0300, Peter Ujfalusi wrote: > The DRA7x has more peripherals with DMA requests than the sDMA can handle: > 205 vs 127. All DMA requests are routed through the DMA crossbar, which can > be configured to route selected incoming DMA requests to specific sDMA >

[PATCH v4 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-04-08 Thread Peter Ujfalusi
The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific sDMA request. Signed-off-by: Peter Ujfalusi --- drivers/dma/Kconfig

[PATCH v4 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-04-08 Thread Peter Ujfalusi
The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific sDMA request. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com ---

Re: [PATCH v4 3/8] dmaengine: Add driver for TI DMA crossbar on DRA7x

2015-04-08 Thread Maxime Ripard
Hi, On Wed, Apr 08, 2015 at 04:14:47PM +0300, Peter Ujfalusi wrote: The DRA7x has more peripherals with DMA requests than the sDMA can handle: 205 vs 127. All DMA requests are routed through the DMA crossbar, which can be configured to route selected incoming DMA requests to specific sDMA