Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, On Tue 24 Apr 2018 at 15:53, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, On Tue 24 Apr 2018 at 15:53, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva ---

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV2680 camera sensor. > > Reviewed-by: Rob Herring > CC: devicet...@vger.kernel.org > Signed-off-by: Rui Miguel Silva >

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV2680 camera sensor. > > Reviewed-by: Rob Herring > CC: devicet...@vger.kernel.org > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/i2c/ov2680.txt | 40

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

On Mon, Apr 23, 2018 at 12:09 PM, Rui Miguel Silva wrote: > Yes, you are correct, I will fix this, and the dts entry. As this pin has both reset and powerdown functionalities, maybe you can name the property as 'reset-gpios' Thanks

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

On Mon, Apr 23, 2018 at 12:09 PM, Rui Miguel Silva wrote: > Yes, you are correct, I will fix this, and the dts entry. As this pin has both reset and powerdown functionalities, maybe you can name the property as 'reset-gpios' Thanks

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, Thanks for the review. On Mon 23 Apr 2018 at 14:11, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: +Optional Properties: +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, +

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Fabio, Thanks for the review. On Mon 23 Apr 2018 at 14:11, Fabio Estevam wrote: Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: +Optional Properties: +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, +if any. This is an

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > +Optional Properties: > +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, > +if any. This is an active high signal to the OV2680. I looked at the OV2680

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > +Optional Properties: > +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, > +if any. This is an active high signal to the OV2680. I looked at the OV2680 datasheet and I see a pin

[PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 40 +++ 1 file changed, 40

[PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Add device tree binding documentation for the OV2680 camera sensor. Reviewed-by: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 40 +++ 1 file changed, 40 insertions(+) create mode 100644