Re: [PATCH v5 4/7] pwm: pca9685: Reset registers to POR state in probe

2021-03-04 Thread Clemens Gruber
On Mon, Mar 01, 2021 at 10:46:33PM +0100, Uwe Kleine-König wrote: > Hello Clemens, > > On Tue, Dec 15, 2020 at 10:22:25PM +0100, Clemens Gruber wrote: > > Reset the prescale and ON/OFF registers to their POR default state in > > the probe function. Otherwise, the PWMs could still be active after

Re: [PATCH v5 4/7] pwm: pca9685: Reset registers to POR state in probe

2021-03-01 Thread Uwe Kleine-König
Hello Clemens, On Tue, Dec 15, 2020 at 10:22:25PM +0100, Clemens Gruber wrote: > Reset the prescale and ON/OFF registers to their POR default state in > the probe function. Otherwise, the PWMs could still be active after a > watchdog reset and reboot, etc. My memories are swapped out because

Re: [PATCH v5 4/7] pwm: pca9685: Reset registers to POR state in probe

2020-12-17 Thread Clemens Gruber
On Wed, Dec 16, 2020 at 11:02:03PM -0500, Sven Van Asbroeck wrote: > Hi Clemens, minor nit below. > > On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber > wrote: > > > > Reset the prescale and ON/OFF registers to their POR default state in > > the probe function. Otherwise, the PWMs could still be

Re: [PATCH v5 4/7] pwm: pca9685: Reset registers to POR state in probe

2020-12-16 Thread Sven Van Asbroeck
Hi Clemens, minor nit below. On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber wrote: > > Reset the prescale and ON/OFF registers to their POR default state in > the probe function. Otherwise, the PWMs could still be active after a > watchdog reset and reboot, etc. > > Signed-off-by: Clemens Gruber

[PATCH v5 4/7] pwm: pca9685: Reset registers to POR state in probe

2020-12-15 Thread Clemens Gruber
Reset the prescale and ON/OFF registers to their POR default state in the probe function. Otherwise, the PWMs could still be active after a watchdog reset and reboot, etc. Signed-off-by: Clemens Gruber --- drivers/pwm/pwm-pca9685.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)